[jira] [Created] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

Jerome Wolff (Jira)
Matt Benson created PROXY-18:
--------------------------------

             Summary: Invocation should return the proxy object, rather than the target, from #getProxy()
                 Key: PROXY-18
                 URL: https://issues.apache.org/jira/browse/PROXY-18
             Project: Commons Proxy
          Issue Type: Improvement
    Affects Versions: 1.0
            Reporter: Matt Benson


1. It's nobody's business but the proxy's creator what the target object is.
2. Unless the proxy instance is available, e.g. fluent interfaces cannot be properly proxied.

It's possible that _both_ the {{target}} and {{proxy}} objects could be provided by the {{Invocation}} but as already stated I find that neither necessary nor desirable.  I'll be attaching a patch for community review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

Jerome Wolff (Jira)

     [ https://issues.apache.org/jira/browse/PROXY-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated PROXY-18:
-----------------------------

    Attachment: PROXY-18.patch.txt

Contains the necessary changes to satisfy this request.  Note that these changes break compatibility with 1.0 behavior and that the tests (actually one test superclass) had to be changed to accommodate the change.
               

> Invocation should return the proxy object, rather than the target, from #getProxy()
> -----------------------------------------------------------------------------------
>
>                 Key: PROXY-18
>                 URL: https://issues.apache.org/jira/browse/PROXY-18
>             Project: Commons Proxy
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Matt Benson
>         Attachments: PROXY-18.patch.txt
>
>
> 1. It's nobody's business but the proxy's creator what the target object is.
> 2. Unless the proxy instance is available, e.g. fluent interfaces cannot be properly proxied.
> It's possible that _both_ the {{target}} and {{proxy}} objects could be provided by the {{Invocation}} but as already stated I find that neither necessary nor desirable.  I'll be attaching a patch for community review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

Jerome Wolff (Jira)
In reply to this post by Jerome Wolff (Jira)

    [ https://issues.apache.org/jira/browse/PROXY-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459511#comment-13459511 ]

James Carman commented on PROXY-18:
-----------------------------------

It has been so long since I've been in this code.  I can't recall why I structured the unit tests to specifically look for this behavior.  If it doesn't make sense, let's change it.  Good catch!  
               

> Invocation should return the proxy object, rather than the target, from #getProxy()
> -----------------------------------------------------------------------------------
>
>                 Key: PROXY-18
>                 URL: https://issues.apache.org/jira/browse/PROXY-18
>             Project: Commons Proxy
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Matt Benson
>         Attachments: PROXY-18.patch.txt
>
>
> 1. It's nobody's business but the proxy's creator what the target object is.
> 2. Unless the proxy instance is available, e.g. fluent interfaces cannot be properly proxied.
> It's possible that _both_ the {{target}} and {{proxy}} objects could be provided by the {{Invocation}} but as already stated I find that neither necessary nor desirable.  I'll be attaching a patch for community review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

Jerome Wolff (Jira)
In reply to this post by Jerome Wolff (Jira)

     [ https://issues.apache.org/jira/browse/PROXY-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated PROXY-18:
-----------------------------

    Fix Version/s: 2.0
   

> Invocation should return the proxy object, rather than the target, from #getProxy()
> -----------------------------------------------------------------------------------
>
>                 Key: PROXY-18
>                 URL: https://issues.apache.org/jira/browse/PROXY-18
>             Project: Commons Proxy
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Matt Benson
>             Fix For: 2.0
>
>         Attachments: PROXY-18.patch.txt
>
>
> 1. It's nobody's business but the proxy's creator what the target object is.
> 2. Unless the proxy instance is available, e.g. fluent interfaces cannot be properly proxied.
> It's possible that _both_ the {{target}} and {{proxy}} objects could be provided by the {{Invocation}} but as already stated I find that neither necessary nor desirable.  I'll be attaching a patch for community review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (PROXY-18) Invocation should return the proxy object, rather than the target, from #getProxy()

Jerome Wolff (Jira)
In reply to this post by Jerome Wolff (Jira)

     [ https://issues.apache.org/jira/browse/PROXY-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved PROXY-18.
------------------------------

    Resolution: Fixed

Thanks for your attention, James.

Committed revision 1388097.
               

> Invocation should return the proxy object, rather than the target, from #getProxy()
> -----------------------------------------------------------------------------------
>
>                 Key: PROXY-18
>                 URL: https://issues.apache.org/jira/browse/PROXY-18
>             Project: Commons Proxy
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Matt Benson
>             Fix For: 2.0
>
>         Attachments: PROXY-18.patch.txt
>
>
> 1. It's nobody's business but the proxy's creator what the target object is.
> 2. Unless the proxy instance is available, e.g. fluent interfaces cannot be properly proxied.
> It's possible that _both_ the {{target}} and {{proxy}} objects could be provided by the {{Invocation}} but as already stated I find that neither necessary nor desirable.  I'll be attaching a patch for community review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira