[jira] [Created] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
[Graph Coloring] Generic iterable set of color
----------------------------------------------

                 Key: SANDBOX-338
                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
             Project: Commons Sandbox
          Issue Type: Improvement
          Components: Graph
            Reporter: Marco Speranza
            Priority: Minor
         Attachments: GenericIterableColorSet.patch

Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.

WDYT?

Looking forward your comments.

have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment: GenericIterableColorSet.patch

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059846#comment-13059846 ]

Marco Speranza commented on SANDBOX-338:
----------------------------------------

Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.

WDYT?

Looking forward your comments.

have a nice day

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059846#comment-13059846 ]

Marco Speranza edited comment on SANDBOX-338 at 7/5/11 11:51 AM:
-----------------------------------------------------------------

Here is my patch...

ciao

      was (Author: marco.speranza):
    Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.

WDYT?

Looking forward your comments.

have a nice day
 

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059857#comment-13059857 ]

Simone Tripodi commented on SANDBOX-338:
----------------------------------------

-1

{{Iterable}} can contains duplicates... ;)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059872#comment-13059872 ]

Marco Speranza commented on SANDBOX-338:
----------------------------------------

ouch ;) you're right. So we can leave the generic {{Set<C>}} WDYT?



> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059874#comment-13059874 ]

Simone Tripodi commented on SANDBOX-338:
----------------------------------------

yes, a generic {{Set<C>}} is the way, looking forward to hear from you soon! ;)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment: GenericIterableColorSet-Fixed.patch

here is the patch modified.

ciao ;)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet-Fixed.patch, GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059980#comment-13059980 ]

Simone Tripodi commented on SANDBOX-338:
----------------------------------------

nice, it looks much better now :)

anyway, two minor observations:

 * there's a typo in {{GraphColoingBackTrackingTestCase}}, should be {{GraphColoringBackTrackingTestCase}};
 * I don't see useful having the {{GraphUtils.createColorsList()}} method in {{GraphUtils}} class, since it is required only for _coloring_ problem, I'd suggest you relocating it.

TIA, ciao ;)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet-Fixed.patch, GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment:     (was: GenericIterableColorSet-Fixed.patch)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment:     (was: GenericIterableColorSet.patch)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment: GenericIterableColorSet.patch

Hi Simo, tnx for your review and I apologise for my mistakes ;)

I fixed the patch.
I removed the previous patches  ;)

have a nice day :)


> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060069#comment-13060069 ]

Simone Tripodi commented on SANDBOX-338:
----------------------------------------

Ciao Marco!

I'm experiencing difficulties on applying the patch, the problem I have is the following:

{code}
$ patch -p0 < GenericIterableColorSet.patch
patching file src/test/java/org/apache/commons/graph/utils/GraphUtils.java
can't find file to patch at input line 102
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java
|===================================================================
|--- src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java (revision 1143025)
|+++ src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java (working copy)
--------------------------
File to patch:
{code}

I think the reason is on:


{code}
Index: src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java
===================================================================
--- src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java (revision 1143025)
+++ src/test/java/org/apache/commons/graph/coloring/GraphColoringBackTrackingTestCase.java (working copy)
{code}

Can you provide a fresh new patch after updating the code please?
TIA, have a nice day!


> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Speranza updated SANDBOX-338:
-----------------------------------

    Attachment: GenericIterableColorSet-fix.patch

Hi Simo, I Fixed the patch, now is ok ;)

ciao ciao

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet-fix.patch, GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SANDBOX-338) [Graph Coloring] Generic iterable set of color

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved SANDBOX-338.
------------------------------------

    Resolution: Fixed
      Assignee: Simone Tripodi

It worked, patch applied, see [r1143206|http://svn.apache.org/viewvc?view=revision&revision=1143206]
Thanks!!!

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Assignee: Simone Tripodi
>            Priority: Minor
>         Attachments: GenericIterableColorSet-fix.patch, GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to generalize the APIs I changed the color {{Set}} with {{Iterable}} and furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira