[jira] [Created] (SANDBOX-407) Reduce visibility of methods in internal classes

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SANDBOX-407) Reduce visibility of methods in internal classes

ASF GitHub Bot (Jira)
Reduce visibility of methods in internal classes
------------------------------------------------

                 Key: SANDBOX-407
                 URL: https://issues.apache.org/jira/browse/SANDBOX-407
             Project: Commons Sandbox
          Issue Type: Improvement
          Components: CSV
            Reporter: Sebb


At present the CharBuffer and ExtendedBufferedReader classes are package protected, but have public methods.

Maybe worth making the methods package-protected as well?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANDBOX-407) Reduce visibility of methods in internal classes

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/SANDBOX-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223652#comment-13223652 ]

Emmanuel Bourg commented on SANDBOX-407:
----------------------------------------

Not sure to understand the need to do this, but why not.
               

> Reduce visibility of methods in internal classes
> ------------------------------------------------
>
>                 Key: SANDBOX-407
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-407
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: CSV
>            Reporter: Sebb
>
> At present the CharBuffer and ExtendedBufferedReader classes are package protected, but have public methods.
> Maybe worth making the methods package-protected as well?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SANDBOX-407) Reduce visibility of methods in internal classes

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Bourg resolved SANDBOX-407.
------------------------------------

       Resolution: Fixed
    Fix Version/s: CSV 1.0

Done, unfortunately I had to leave toString() public ;)
               

> Reduce visibility of methods in internal classes
> ------------------------------------------------
>
>                 Key: SANDBOX-407
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-407
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: CSV
>            Reporter: Sebb
>             Fix For: CSV 1.0
>
>
> At present the CharBuffer and ExtendedBufferedReader classes are package protected, but have public methods.
> Maybe worth making the methods package-protected as well?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira