[jira] [Created] (SANDBOX-429) [BeanUtils2] Implement unit tests for MethodsRegistry

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SANDBOX-429) [BeanUtils2] Implement unit tests for MethodsRegistry

Gary D. Gregory (Jira)
Benedikt Ritter created SANDBOX-429:
---------------------------------------

             Summary: [BeanUtils2] Implement unit tests for MethodsRegistry
                 Key: SANDBOX-429
                 URL: https://issues.apache.org/jira/browse/SANDBOX-429
             Project: Commons Sandbox
          Issue Type: Sub-task
          Components: BeanUtils2
    Affects Versions: Nightly Builds
            Reporter: Benedikt Ritter
            Priority: Trivial




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-429) [BeanUtils2] Implement unit tests for MethodsRegistry

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-429:
------------------------------------

    Attachment: SANDBOX-429.patch

I've uploaded a patch for this issue. I'm not sure how to test all possible execution paths in resolveAccessible() without defining a bunch of new classes just for this purpose. I've marked this as a TODO.
               

> [BeanUtils2] Implement unit tests for MethodsRegistry
> -----------------------------------------------------
>
>                 Key: SANDBOX-429
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-429
>             Project: Commons Sandbox
>          Issue Type: Sub-task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Priority: Trivial
>         Attachments: SANDBOX-429.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANDBOX-429) [BeanUtils2] Implement unit tests for MethodsRegistry

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated SANDBOX-429:
------------------------------------

    Attachment: SANDBOX-429v2.patch

Woops, I've just noticed, that the first version of my patch does not contain a test bean class I've written. Please use v2.

ExceptionBean is a class I've used for the test cases for SANDBOX-423 but it is useful for methods registry tests also. It defines some methods with protected, private and package visibility to test exception handling in cases, when methods are not accessible to the BU2 code.
               

> [BeanUtils2] Implement unit tests for MethodsRegistry
> -----------------------------------------------------
>
>                 Key: SANDBOX-429
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-429
>             Project: Commons Sandbox
>          Issue Type: Sub-task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Priority: Trivial
>         Attachments: SANDBOX-429.patch, SANDBOX-429v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SANDBOX-429) [BeanUtils2] Implement unit tests for MethodsRegistry

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/SANDBOX-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved SANDBOX-429.
------------------------------------

    Resolution: Fixed
      Assignee: Simone Tripodi

patch applied, see revision 1364579

two trivial observations:

 * A typo in comment, _Util_ was marked as error by the spellchecker, I replaced it with _Utility_;

 * I renamed the {{ExceptionBean}} to {{ThrowingExceptionBean}} to better understand what id does.

thanks a lot once again!
               

> [BeanUtils2] Implement unit tests for MethodsRegistry
> -----------------------------------------------------
>
>                 Key: SANDBOX-429
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-429
>             Project: Commons Sandbox
>          Issue Type: Sub-task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Assignee: Simone Tripodi
>            Priority: Trivial
>         Attachments: SANDBOX-429.patch, SANDBOX-429v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira