[jira] [Created] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
Farrukh Najmi created SANSELAN-82:
-------------------------------------

             Summary: Generate tests.jar so client projects can leverage test image data easily
                 Key: SANSELAN-82
                 URL: https://issues.apache.org/jira/browse/SANSELAN-82
             Project: Commons Sanselan
          Issue Type: Improvement
          Components: Build
    Affects Versions: 0.97
            Reporter: Farrukh Najmi
            Priority: Minor
             Fix For: 1.0


Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.

The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.

{code}
Index: pom.xml
===================================================================
--- pom.xml     (revision 1354112)
+++ pom.xml     (working copy)
@@ -89,6 +89,14 @@
       </plugin>
       <plugin>
         <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <goals>
+              <goal>test-jar</goal>
+            </goals>
+          </execution>
+        </executions>
+        
         <configuration>
           <archive>
             <manifestEntries>
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SANSELAN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Farrukh Najmi updated SANSELAN-82:
----------------------------------

    Attachment: SANSELAN-82-patch.txt

Proposed patch to address this issue.
               

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: SANSELAN-82
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-82
>             Project: Commons Sanselan
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/SANSELAN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401644#comment-13401644 ]

Farrukh Najmi edited comment on SANSELAN-82 at 6/26/12 9:00 PM:
----------------------------------------------------------------

Proposed patch to address this issue. Note that builds with proposed patch will not include test images until SANSELAN-83 is addressed.
               
      was (Author: farrukhnajmi):
    Proposed patch to address this issue.
                 

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: SANSELAN-82
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-82
>             Project: Commons Sanselan
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/SANSELAN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401994#comment-13401994 ]

Joerg Schaible commented on SANSELAN-82:
----------------------------------------

-1

A test artifact is supposed to contain the test classes and their necessary ressources (i.e. stuff that is loaded with the class loader). To create such an artifact just because you want to access the test *data* (which does definitely *not* belogn to such an artifact) is simply wrong.
               

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: SANSELAN-82
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-82
>             Project: Commons Sanselan
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Moved] (IMAGING-84) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/IMAGING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joerg Schaible moved SANSELAN-82 to IMAGING-84:
-----------------------------------------------

        Fix Version/s:     (was: 1.0)
          Component/s:     (was: Build)
                       Build
    Affects Version/s:     (was: 0.97)
                       0.97
                  Key: IMAGING-84  (was: SANSELAN-82)
              Project: Commons Imaging  (was: Commons Sanselan)
   

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: IMAGING-84
>                 URL: https://issues.apache.org/jira/browse/IMAGING-84
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (IMAGING-84) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/IMAGING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403077#comment-13403077 ]

Farrukh Najmi commented on IMAGING-84:
--------------------------------------

Using test data is not always the only reason to have a tests.jar artifact from a project. Another reason is when a project extends another project then it may want to also the base project's test classes as part of its own test suite. Do you see a downside to the project producing a tests.jar artifact?

Also, please see my comment on IMAGING-83 on why I think it is not unusual to load test data from the classpath in junit tests.

               

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: IMAGING-84
>                 URL: https://issues.apache.org/jira/browse/IMAGING-84
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (IMAGING-84) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/IMAGING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403077#comment-13403077 ]

Farrukh Najmi edited comment on IMAGING-84 at 6/28/12 1:27 PM:
---------------------------------------------------------------

Using test data is not always the only reason to have a tests.jar artifact from a project. Another reason is when a project extends another project then it may want to also the base project's test classes as part of its own test suite. Do you see a downside to the project producing a tests.jar artifact?

Also, please see my comment on IMAGING-85 on why I think it is not unusual to load test data from the classpath in junit tests.

Feel free to close the issue if you and other dev team members are still -1 on this.

               
      was (Author: farrukhnajmi):
    Using test data is not always the only reason to have a tests.jar artifact from a project. Another reason is when a project extends another project then it may want to also the base project's test classes as part of its own test suite. Do you see a downside to the project producing a tests.jar artifact?

Also, please see my comment on IMAGING-83 on why I think it is not unusual to load test data from the classpath in junit tests.

                 

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: IMAGING-84
>                 URL: https://issues.apache.org/jira/browse/IMAGING-84
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (IMAGING-84) Generate tests.jar so client projects can leverage test image data easily

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/IMAGING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Damjan Jovanovic resolved IMAGING-84.
-------------------------------------

    Resolution: Later

Deferring to after the 1.0 release.

               

> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: IMAGING-84
>                 URL: https://issues.apache.org/jira/browse/IMAGING-84
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set.
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira