[jira] Created: (VFS-338) Possible crash in extractWindowsRootPrefix method

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (VFS-338) Possible crash in extractWindowsRootPrefix method

Gilles (Jira)
Possible crash in extractWindowsRootPrefix method
-------------------------------------------------

                 Key: VFS-338
                 URL: https://issues.apache.org/jira/browse/VFS-338
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: 2.0
         Environment: Windows
            Reporter: Daniel R


extractWindowsRootPrefix method has a possible crash. Found it trying to get special windows working.

        if (startPos == maxlen && name.length() > startPos && name.charAt(startPos + 1) == '/')
        {
            // Too many '/'
            throw new FileSystemException("vfs.provider.local/not-absolute-file-name.error", uri);
        }

This should be something like so:

        if (startPos == maxlen && name.length() > startPos && name.length() > (startPos + 1) && name.charAt(startPos + 1) == '/')
        {
            // Too many '/'
            throw new FileSystemException("vfs.provider.local/not-absolute-file-name.error", uri);
        }

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (VFS-338) Possible crash in extractWindowsRootPrefix method

Gilles (Jira)

    [ https://issues.apache.org/jira/browse/VFS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113925#comment-13113925 ]

Ralph Goers commented on VFS-338:
---------------------------------

I don't have a Windows environment to test on. I am hesitant to apply a patch that is "something like" the provided code. Can you supply a patch and a test that verifies it?

> Possible crash in extractWindowsRootPrefix method
> -------------------------------------------------
>
>                 Key: VFS-338
>                 URL: https://issues.apache.org/jira/browse/VFS-338
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: Windows
>            Reporter: Daniel R
>
> extractWindowsRootPrefix method has a possible crash. Found it trying to get special windows working.
>         if (startPos == maxlen && name.length() > startPos && name.charAt(startPos + 1) == '/')
>         {
>             // Too many '/'
>             throw new FileSystemException("vfs.provider.local/not-absolute-file-name.error", uri);
>         }
> This should be something like so:
>         if (startPos == maxlen && name.length() > startPos && name.length() > (startPos + 1) && name.charAt(startPos + 1) == '/')
>         {
>             // Too many '/'
>             throw new FileSystemException("vfs.provider.local/not-absolute-file-name.error", uri);
>         }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira