[jira] Created: (VFS-345) Regression: FTP Provider does not support symbolic links correctly

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (VFS-345) Regression: FTP Provider does not support symbolic links correctly

Gary D. Gregory (Jira)
Regression: FTP Provider does not support symbolic links correctly
------------------------------------------------------------------

                 Key: VFS-345
                 URL: https://issues.apache.org/jira/browse/VFS-345
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: Nightly Builds
            Reporter: Andreas Persson


After the fix from VFS-307, the FTP provider does not handle symbolic links correctly.

A symlink to a directory returns false from exists(). getType() returns FileType.IMAGINARY.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (VFS-345) Regression: FTP Provider does not support symbolic links correctly

Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/VFS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978819#action_12978819 ]

Ralph Goers commented on VFS-345:
---------------------------------

I need a bit more information as I can't tell what was changed in VFS-307.  What class should I look at?

> Regression: FTP Provider does not support symbolic links correctly
> ------------------------------------------------------------------
>
>                 Key: VFS-345
>                 URL: https://issues.apache.org/jira/browse/VFS-345
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Andreas Persson
>
> After the fix from VFS-307, the FTP provider does not handle symbolic links correctly.
> A symlink to a directory returns false from exists(). getType() returns FileType.IMAGINARY.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (VFS-345) Regression: FTP Provider does not support symbolic links correctly

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/VFS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978828#action_12978828 ]

Andreas Persson commented on VFS-345:
-------------------------------------

FTPClientWrapper: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FTPClientWrapper.java?r1=804644&r2=940808&diff_format=h

I don't understand the code enough to tell how the VFS-307 patch works, but when I removed these lines:

        files = getFtpClient().listFiles(relPath);
        if (FTPReply.isPositiveCompletion(getFtpClient().getReplyCode()))
        {
            return files;
        }

which were added in VFS-307, the bug disappeared.


> Regression: FTP Provider does not support symbolic links correctly
> ------------------------------------------------------------------
>
>                 Key: VFS-345
>                 URL: https://issues.apache.org/jira/browse/VFS-345
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Andreas Persson
>
> After the fix from VFS-307, the FTP provider does not handle symbolic links correctly.
> A symlink to a directory returns false from exists(). getType() returns FileType.IMAGINARY.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (VFS-345) Regression: FTP Provider does not support symbolic links correctly

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/VFS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274240#comment-13274240 ]

Andreas Persson commented on VFS-345:
-------------------------------------

I've investigated this a little bit further.

The structure that causes the bug for me is:

/dir1/dir2/dir3/file
/link -> /dir1/dir2

- then, the URL ftp://server/link/dir3 returns false from exists().

This is with a Solaris ftp server. On Apache FtpServer it works.
               

> Regression: FTP Provider does not support symbolic links correctly
> ------------------------------------------------------------------
>
>                 Key: VFS-345
>                 URL: https://issues.apache.org/jira/browse/VFS-345
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Andreas Persson
>
> After the fix from VFS-307, the FTP provider does not handle symbolic links correctly.
> A symlink to a directory returns false from exists(). getType() returns FileType.IMAGINARY.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira