[jira] [Created] (VFS-352) ZipFileSystem makes improper assumptions about FileCache

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (VFS-352) ZipFileSystem makes improper assumptions about FileCache

ASF GitHub Bot (Jira)
ZipFileSystem makes improper assumptions about FileCache
--------------------------------------------------------

                 Key: VFS-352
                 URL: https://issues.apache.org/jira/browse/VFS-352
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: 1.0
         Environment: Java 1.6
            Reporter: Alex Bertram


Upon init(), ZipFileSystem enumerates all the zip file entries and stores them in the global FilesCache as well as a "strongRef" array.

The ZipFileSystem implementation assumes that this will be sufficient to keep all entries in the cache, and so if the cache misses in AbstractFileSystem, ZipFileSystem assumes that the file does not exist and returns an imaginary file.

This implementation assumes that the WeakRefFilesCache is being used. If NullFilesCache or LRUFilesCaches is used, these assumptions will fail and ZipFileSystem will fail to resolve valid existing files within the system.

ZipFileSystem should maintain its own internal cache instead.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (VFS-352) ZipFileSystem makes improper assumptions about FileCache

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ralph Goers resolved VFS-352.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

ZipFileSystem now uses an internal Map and ignores the FileSystemManager's cache. Please verify and close.

> ZipFileSystem makes improper assumptions about FileCache
> --------------------------------------------------------
>
>                 Key: VFS-352
>                 URL: https://issues.apache.org/jira/browse/VFS-352
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Java 1.6
>            Reporter: Alex Bertram
>              Labels: cache, zip
>             Fix For: 2.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Upon init(), ZipFileSystem enumerates all the zip file entries and stores them in the global FilesCache as well as a "strongRef" array.
> The ZipFileSystem implementation assumes that this will be sufficient to keep all entries in the cache, and so if the cache misses in AbstractFileSystem, ZipFileSystem assumes that the file does not exist and returns an imaginary file.
> This implementation assumes that the WeakRefFilesCache is being used. If NullFilesCache or LRUFilesCaches is used, these assumptions will fail and ZipFileSystem will fail to resolve valid existing files within the system.
> ZipFileSystem should maintain its own internal cache instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira