[jira] [Created] (VFS-357) FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (VFS-357) FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.

ASF GitHub Bot (Jira)
FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.
------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: VFS-357
                 URL: https://issues.apache.org/jira/browse/VFS-357
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: 1.0
            Reporter: Miroslav Pokorny


RamFileSystemConfigBuilder also exhibits the same problem. The documentation does not make it sure if the max size is read during the factory or while running...
I believe it would be simpler to remove the singletonness and allow different objects to be created and set with their own properties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (VFS-357) FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/VFS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067595#comment-13067595 ]

Miroslav Pokorny commented on VFS-357:
--------------------------------------

Im sorry my original statement was wrong, either way it would lead to less confusion (at least for me) if the builder wasnt a singleton or the doco stated it doenst contain state.

> FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: VFS-357
>                 URL: https://issues.apache.org/jira/browse/VFS-357
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Miroslav Pokorny
>
> RamFileSystemConfigBuilder also exhibits the same problem. The documentation does not make it sure if the max size is read during the factory or while running...
> I believe it would be simpler to remove the singletonness and allow different objects to be created and set with their own properties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (VFS-357) FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ralph Goers resolved VFS-357.
-----------------------------

    Resolution: Won't Fix

While I agree with this - I actually looked into providing an alternative to the ConfigBuilders a while ago - it just isn't worth the trouble in the current code base. VFS 3.0 should be based on Java 7 which should help clean this up.

> FtpFileSystemConfigBuilder and other builders are all singletons which leads to problems if one wishes ftp connections with different incompatible settings.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: VFS-357
>                 URL: https://issues.apache.org/jira/browse/VFS-357
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Miroslav Pokorny
>
> RamFileSystemConfigBuilder also exhibits the same problem. The documentation does not make it sure if the max size is read during the factory or while running...
> I believe it would be simpler to remove the singletonness and allow different objects to be created and set with their own properties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira