[jira] [Created] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)
Gary D. Gregory created VFS-429:
-----------------------------------

             Summary: Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
                 Key: VFS-429
                 URL: https://issues.apache.org/jira/browse/VFS-429
             Project: Commons VFS
          Issue Type: Improvement
    Affects Versions: 2.0
            Reporter: Gary D. Gregory


Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).

This can be cleaned up nicely with generics.

Thoughts for or against?

Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated VFS-429:
--------------------------------

    Attachment: AFO-generics.diff
   

> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>         Attachments: AFO-generics.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated VFS-429:
--------------------------------

    Attachment:     (was: AFO-generics.diff)
   

> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>         Attachments: vfs-afs.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated VFS-429:
--------------------------------

    Attachment: vfs-afs.diff

Complete clean up implementation I will commit if I do not hear objections ASAP.
               

> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>         Attachments: vfs-afs.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418120#comment-13418120 ]

Simone Tripodi commented on VFS-429:
------------------------------------

+1

even if I am not familiar with VFS codebase, the feedback I can provide you as a potential user is that the patch shows a very clear and comprensive code cleanup.

If it breaks the backward compatibility, don't stop and go for a major release :)

well done!
               

> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>         Attachments: vfs-afs.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved VFS-429.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

commit -m "[VFS-429] Remove extra FileSystem ivar in AbstractFileObject subclasses with generics." (14 paths specified)
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/DelegateFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/Bzip2FileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/compressed/CompressedFileFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/gzip/GzipFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/http/HttpFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/local/LocalFile.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/url/UrlFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/src/changes/changes.xml
    Transmitting file data ...
    Committed revision 1363962.
               

> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>             Fix For: 2.1
>
>         Attachments: vfs-afs.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira