[jira] [Resolved] (MATH-811) Improve event detection by selecting g function slope

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Resolved] (MATH-811) Improve event detection by selecting g function slope

JIN XU (Jira)

     [ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luc Maisonobe resolved MATH-811.

       Resolution: Fixed
    Fix Version/s: 3.2

Fixed in subversion repository as of r1458298.

The method used is completely different from what was suggested in the
request report. It is fully compatible with previous versions and most
importantly has no side effects on users that do not need this feature,
as it is based on an upstream filtering of the event definition
function. The events detection logic is not modified and in fact it does
not even know events are filtered before they are detected.

It should theoretically be possible to stack filters (this has not been tested yet). With k levels of filtering, the number of events that are really triggered should be n/2^k where n is the raw number of events, without any filtering.

Thanks for the report.

> Improve event detection by selecting g function slope
> -----------------------------------------------------
>                 Key: MATH-811
>                 URL: https://issues.apache.org/jira/browse/MATH-811
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Yannick TANGUY
>             Fix For: 3.2
>         Attachments: JIRA-811_slope_selection.patch, JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_V3.patch, JIRA-811_slope_selection_V3_with_spaces.patch, JIRA-811_slope_selection_with_spaces.patch
> We would like to select g function slope in CommonsMath event detection feature.
> This would improve event detection for the final user (the possibility to ignore some events, and less computation time) and also correct a bug found while using OREKIT (see https://www.orekit.org/forge/issues/104) in our applications.
> The modification consists in adding a method (getSlopeSelection() : int) in EventHandler, and modifying one conditionnal in the method evaluateStep (class EventState).
> We can provide modified code and unitary tests for this feature.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira