[jira] Resolved: (NET-74) [net]Telnet option handlers subnegotiations does not handle 0xFF correctly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (NET-74) [net]Telnet option handlers subnegotiations does not handle 0xFF correctly

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-74.
---------------------

    Resolution: Not A Problem

Note that the individual handlers have to deal with doubling any 255 bytes themselves - TelnetClient only adds the IAC SB / IAC SE wrapper.

Only the WindowSize option handler can generate the byte 255, and it already takes this into account.

Added a test case for the code.


> [net]Telnet option handlers subnegotiations does not handle 0xFF correctly
> --------------------------------------------------------------------------
>
>                 Key: NET-74
>                 URL: https://issues.apache.org/jira/browse/NET-74
>             Project: Commons Net
>          Issue Type: Bug
>          Components: Telnet
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Yuval Kashtan
>            Priority: Minor
>
> in accordance to RFC855: "Finally, if parameters in an option "subnegotiation"
> include a byte with a value of 255, it is necessary to double this byte in
> accordance the general TELNET rules."
> I've actually encontered this while implementing WindowSize option handler, but
> it seems that all the currently avilable handlers are vulnerable to this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.