[jira] [Work logged] (TEXT-104) Jaro Winkler Distance refers to similarity

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Work logged] (TEXT-104) Jaro Winkler Distance refers to similarity

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/TEXT-104?focusedWorklogId=199565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199565 ]

ASF GitHub Bot logged work on TEXT-104:

                Author: ASF GitHub Bot
            Created on: 16/Feb/19 09:08
            Start Date: 16/Feb/19 09:08
    Worklog Time Spent: 10m
      Work Description: kinow commented on pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#discussion_r257453767

 File path: src/main/java/org/apache/commons/text/similarity/package-info.java
 @@ -29,6 +29,7 @@
  * <li>{@link org.apache.commons.text.similarity.FuzzyScore Fuzzy Score}</li>
  * <li>{@link org.apache.commons.text.similarity.HammingDistance Hamming Distance}</li>
  * <li>{@link org.apache.commons.text.similarity.JaroWinklerDistance Jaro-Winkler Distance}</li>
+ * <li>{@link org.apache.commons.text.similarity.JaroWinklerSimilarity Jaro-Winkler Similarity}</li>
 Review comment:
   Thanks for updating the docs!!! :clap: Would you mind updating `userguide.xml` too?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]

Issue Time Tracking

    Worklog Id:     (was: 199565)
    Time Spent: 0.5h  (was: 20m)

> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>                 Key: TEXT-104
>                 URL: https://issues.apache.org/jira/browse/TEXT-104
>             Project: Commons Text
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Nikos Karagiannakis
>            Priority: Trivial
>             Fix For: 2.0
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> The 'apply' method returns the similarity score instead of the distance score as implied from the class name.
> It is stated in the javadoc, but it is not aligned with the approach of the rest similarity scores in the same package (e.g LevenshteinDetailedDistance).
> Maybe a rename of the class or the method to avoid confusion?

This message was sent by Atlassian JIRA