[lang] 2.1RC7 and java < 1.4 [WAS:] DateUtils test fails under 1.2.2 and not under 1.4.2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[lang] 2.1RC7 and java < 1.4 [WAS:] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
Hello:

Note that RC7 does not change any of the issues in this message thread.
The suggestions below cause one odd problem though: For the enum tests,
an ClassNotFoundException is thrown when trying to load the Enum class
from the custom built class loader. Weird.

Gary

-----Original Message-----
From: Gary Gregory
Sent: Friday, May 27, 2005 12:08 AM
To: 'Jakarta Commons Developers List'; [hidden email]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Actually, assuming what is below is acceptable, using Ant 1.6 allows for
a clean up to make the build.xml file shorter with:

    <macrodef name="testit">
        <attribute name="classname"/>
        <sequential>
            <junit printsummary="true" fork="${junit.fork}"
haltonerror="${test.failonerror}">
                <classpath refid="test.classpath"/>
                <test name="@{classname}"/>
            </junit>
        </sequential>
    </macrodef>

    <target name="test.lang" depends="compile.tests">
        <testit classname="org.apache.commons.lang.LangTestSuite"/>
    </target>

    <!-- Ditto for all test targets. -->

Any thoughts on making Ant 1.6 a build pre-req?

Gary

-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 10:56 PM
To: Jakarta Commons Developers List; [hidden email]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Hello Steven and All:

Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.

Instead of using this odd way of invoking unit tests:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <java classname="${test.runner}" fork="${test.fork}"
failonerror="${test.failonerror}">
            <arg value="org.apache.commons.lang.LangTestSuite"/>
            <classpath refid="test.classpath"/>
        </java>
    </target>

I changed this target on my machine to the more standard JUnit
invocation:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
            <classpath refid="test.classpath"/>
            <test name="org.apache.commons.lang.LangTestSuite"/>
        </junit>
    </target>

The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.

Shall I (or Steven) change the JUnit invocation style for all tests?

Gary

-----Original Message-----
From: Simon Kitching [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 9:07 PM
To: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access
to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lang] 2.1RC7 and java < 1.4 [WAS:] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
I actually overlooked your e-mail on this when I back through to decide if
we had resolved everything and I apologize for that.

I don't have any problem with your prosal to make Ant 1.6 a prereq, so I'll
put in my +1.

On 5/29/05, Gary Gregory <[hidden email]> wrote:

>
> Hello:
>
> Note that RC7 does not change any of the issues in this message thread.
> The suggestions below cause one odd problem though: For the enum tests,
> an ClassNotFoundException is thrown when trying to load the Enum class
> from the custom built class loader. Weird.
>
> Gary
>
> -----Original Message-----
> From: Gary Gregory
> Sent: Friday, May 27, 2005 12:08 AM
> To: 'Jakarta Commons Developers List'; [hidden email]
> Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
>
> Actually, assuming what is below is acceptable, using Ant 1.6 allows for
> a clean up to make the build.xml file shorter with:
>
> <macrodef name="testit">
> <attribute name="classname"/>
> <sequential>
> <junit printsummary="true" fork="${junit.fork}"
> haltonerror="${test.failonerror}">
> <classpath refid="test.classpath"/>
> <test name="@{classname}"/>
> </junit>
> </sequential>
> </macrodef>
>
> <target name="test.lang" depends="compile.tests">
> <testit classname="org.apache.commons.lang.LangTestSuite"/>
> </target>
>
> <!-- Ditto for all test targets. -->
>
> Any thoughts on making Ant 1.6 a build pre-req?
>
> Gary
>
> -----Original Message-----
> From: Gary Gregory [mailto:[hidden email]]
> Sent: Thursday, May 26, 2005 10:56 PM
> To: Jakarta Commons Developers List; [hidden email]
> Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
>
> Hello Steven and All:
>
> Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.
>
> Instead of using this odd way of invoking unit tests:
>
> <target name="test.lang" depends="compile.tests">
> <echo message="Running lang package tests ..."/>
> <java classname="${test.runner}" fork="${test.fork}"
> failonerror="${test.failonerror}">
> <arg value="org.apache.commons.lang.LangTestSuite"/>
> <classpath refid="test.classpath"/>
> </java>
> </target>
>
> I changed this target on my machine to the more standard JUnit
> invocation:
>
> <target name="test.lang" depends="compile.tests">
> <echo message="Running lang package tests ..."/>
> <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
> <classpath refid="test.classpath"/>
> <test name="org.apache.commons.lang.LangTestSuite"/>
> </junit>
> </target>
>
> The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.
>
> Shall I (or Steven) change the JUnit invocation style for all tests?
>
> Gary
>
> -----Original Message-----
> From: Simon Kitching [mailto:[hidden email]]
> Sent: Thursday, May 26, 2005 9:07 PM
> To: Jakarta Commons Developers List
> Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
>
> On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> > That is so very odd. I'm at a loss to explain it. I don't have access
> to a
> > system with JDK 1.3 so I'm not able to try it. Maybe someone else can
> try?
>
> I've also tried building with JDK1.2.2 on linux.
>
> I got this as part of the output
> [java] Java 1.3 tests not run since the current version is 1.2.2
> and also got the DateUtilsTest.testRound failure.
>
> No other problems were encountered.
>
> If Gary is running tests on Windows, then his problem might indicate a
> windows-specific issue. Otherwise it looks to me like a system-specific
> problem with Gary's setup.
>
> Regards,
>
> Simon
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

RE: [lang] 2.1RC7 and java < 1.4 [WAS:] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Gary Gregory
Steven:

 

"I actually overlooked your e-mail on this when I back through to decide
if we had resolved everything and I apologize for that."

 

No problem ;-)  Even though building on 1.3.1 (or < 1.4 in general) is
not showstopper issue for me I think we need to address it. I can't
imagine that we will not get a bug report that will lessen public
confidence for 1.3 support.

 

"I don't have any problem with your prosal to make Ant 1.6 a prereq, so
I'll put in my +1."

 

Here is what I propose baring any -1s from others: I'll make the changes
noted below while still using the "old" test invocation style for the
Enum/Enums test. This last class loading problem being a weird one. Hm,
now that I think about it the Enum/Enums will still fail on either 1.3
(no fix: old error; with fix: new class loading problem), sigh. I guess
I or someone else should dig into the class loading issue, which only
happens from the Ant CLI, not when I run the tests from Eclipse.

 

I'll try to get to this later today or tomorrow.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Sunday, May 29, 2005 6:12 AM
To: Jakarta Commons Developers List
Cc: Gary Gregory; [hidden email]
Subject: Re: [lang] 2.1RC7 and java < 1.4 [WAS:] DateUtils test fails
under 1.2.2 and not under 1.4.2

 

I actually overlooked your e-mail on this when I back through to decide
if we had resolved everything and I apologize for that.

I don't have any problem with your prosal to make Ant 1.6 a prereq, so
I'll put in my +1.

On 5/29/05, Gary Gregory < [hidden email]
<mailto:[hidden email]> > wrote:

Hello:

Note that RC7 does not change any of the issues in this message thread.
The suggestions below cause one odd problem though: For the enum tests,
an ClassNotFoundException is thrown when trying to load the Enum class
from the custom built class loader. Weird.

Gary

-----Original Message-----
From: Gary Gregory
Sent: Friday, May 27, 2005 12:08 AM
To: 'Jakarta Commons Developers List'; [hidden email]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Actually, assuming what is below is acceptable, using Ant 1.6 allows for
a clean up to make the build.xml file shorter with:

    <macrodef name="testit">
        <attribute name="classname"/>
        <sequential>
            <junit printsummary="true" fork="${junit.fork}"
haltonerror="${test.failonerror}">
                <classpath refid="test.classpath"/>
                <test name="@{classname}"/>
            </junit>
        </sequential>
    </macrodef>

    <target name="test.lang" depends="compile.tests">
        <testit classname=" org.apache.commons.lang.LangTestSuite"/>
    </target>

    <!-- Ditto for all test targets. -->

Any thoughts on making Ant 1.6 a build pre-req?

Gary

-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 10:56 PM
To: Jakarta Commons Developers List; [hidden email]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Hello Steven and All:

Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.

Instead of using this odd way of invoking unit tests:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <java classname="${test.runner}" fork="${ test.fork}"
failonerror="${test.failonerror}">
            <arg value="org.apache.commons.lang.LangTestSuite"/>
            <classpath refid="test.classpath"/>
        </java>
    </target>

I changed this target on my machine to the more standard JUnit
invocation:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
            <classpath refid="test.classpath"/>
            <test name="org.apache.commons.lang.LangTestSuite "/>
        </junit>
    </target>

The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.

Shall I (or Steven) change the JUnit invocation style for all tests?

Gary

-----Original Message-----
From: Simon Kitching [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 9:07 PM
To: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access
to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 

Reply | Threaded
Open this post in threaded view
|

RE: [lang] 2.1RC7 and java < 1.4

Simon Kitching
On Sun, 2005-05-29 at 11:34 -0400, Gary Gregory wrote:
>  
>
> Here is what I propose baring any -1s from others: I'll make the changes
> noted below while still using the "old" test invocation style for the
> Enum/Enums test. This last class loading problem being a weird one. Hm,
> now that I think about it the Enum/Enums will still fail on either 1.3
> (no fix: old error; with fix: new class loading problem), sigh. I guess
> I or someone else should dig into the class loading issue, which only
> happens from the Ant CLI, not when I run the tests from Eclipse.


I'll just note (again) that all the unit tests work FINE for me with the
Ant CLI (and the Maven CLI), on java 1.2.2, 1.3.1, 1.5.0 (all on Linux).

Not that I have any objection to depending on ant 1.6 for builds if
people want to [alas, it probably means another RC though].

Hmm.. one thing I just noticed though. Normally, foo-src.tar.gz files
unpack into a directory named foo-src. But
commons-lang-2.1-RC7-src.tar.gz unpacks into a directory
"commons-lang-2.1-RC7".

Regards,

Simon



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lang] 2.1RC7 and java < 1.4

Steven Caswell
Gary,

Glad to hear you've made progress.

I will build another RC this evening.

On 5/31/05, Gary Gregory <[hidden email]> wrote:

>
> Hello:
>
> I've finally worked out the oddball build and class loading issue that
> only seems to happen on Windows XP (SP2) since Simon reports that the
> ant build works fine for him on Linux.
>
> I can report success with "ant clean dist-build-2.1 test" on Sun Java
> versions:
>
> 1.5.0_03
> 1.5.0_02
> 1.4.2_08
> 1.3.1_14
>
> In order achieve this; the new build.xml depends on Ant 1.6.
>
> Version 1.2.2_017 hangs miserably for me though, as it did before any of
> these changes.
>
> "[alas, it probably means another RC though]."
>
> Yes, please.
>
> Thanks,
>
> Gary
>
> -----Original Message-----
> From: Simon Kitching [mailto:[hidden email]]
> Sent: Monday, May 30, 2005 12:40 AM
> To: Jakarta Commons Developers List
> Subject: RE: [lang] 2.1RC7 and java < 1.4
>
> On Sun, 2005-05-29 at 11:34 -0400, Gary Gregory wrote:
> >
> >
> > Here is what I propose baring any -1s from others: I'll make the
> changes
> > noted below while still using the "old" test invocation style for the
> > Enum/Enums test. This last class loading problem being a weird one.
> Hm,
> > now that I think about it the Enum/Enums will still fail on either 1.3
> > (no fix: old error; with fix: new class loading problem), sigh. I
> guess
> > I or someone else should dig into the class loading issue, which only
> > happens from the Ant CLI, not when I run the tests from Eclipse.
>
>
> I'll just note (again) that all the unit tests work FINE for me with the
> Ant CLI (and the Maven CLI), on java 1.2.2, 1.3.1, 1.5.0 (all on Linux).
>
> Not that I have any objection to depending on ant 1.6 for builds if
> people want to [alas, it probably means another RC though].
>
> Hmm.. one thing I just noticed though. Normally, foo-src.tar.gz files
> unpack into a directory named foo-src. But
> commons-lang-2.1-RC7-src.tar.gz unpacks into a directory
> "commons-lang-2.1-RC7".
>
> Regards,
>
> Simon
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org