[lang] DateUtils test fails under 1.2.2 and not under 1.4.2

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
All,

I have discovered a group of tests in the DateUtils test case that fails
under 1.2.2 but not under 1.4.2. They are testing the DateUtils round method
when rounding a date in the MET timezone across the start and end of DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run when
the Java version is 1.4, and add a note to the round method javadoc and the
release notes stating that the round method may not work properly in all
cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
Gary,

I have a fix for that problem. I'll go ahead and put up a corrected source
distribution with the fix and without the DateUtilsTest correction so you
can try 1.3.1.


On 5/24/05, Gary Gregory <[hidden email]> wrote:

>
> I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> from src-zip does not make it past text tests:
>
> test.text:
> [echo] Running text package tests ...
> [java] Class not found "org.apache.commons.lang.text.TextTestSuite"
>
> BUILD FAILED
> C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
>
> Which should not be run in the 1st place...
>
> (Ant 1.6.4 and Java 1.4.2_08)
>
> Gary
>
> -----Original Message-----
> From: Steven Caswell [mailto:[hidden email]]
> Sent: Tuesday, May 24, 2005 5:39 PM
> To: Jakarta Commons Developers List
> Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>
> All,
>
> I have discovered a group of tests in the DateUtils test case that fails
>
> under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> method
> when rounding a date in the MET timezone across the start and end of
> DST. If
> I remember correctly, this was in response to a user bug report. In
> particular the test is at line 472 of the testRound method in
> DataUtilsTest.java.
>
> The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
>
> have a 1.3 installation available so I don't know if it passes or fails
> under 1.3.
>
> I propose that we put a condition around the test so that is only run
> when
> the Java version is 1.4, and add a note to the round method javadoc and
> the
> release notes stating that the round method may not work properly in all
>
> cases involving DST rollovers in previous JVMs, with this case as an
> example.
>
> Thoughs?
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org
>



--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they are
modified. I was just too lazy to change it to RC7 for a minor non-code fix,
and since there will probably be an RC7 with the date utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email]> wrote:

>
> Gary,
>
> I have a fix for that problem. I'll go ahead and put up a corrected source
> distribution with the fix and without the DateUtilsTest correction so you
> can try 1.3.1.
>
>
> On 5/24/05, Gary Gregory <[hidden email]> wrote:
> >
> > I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> > from src-zip does not make it past text tests:
> >
> > test.text:
> > [echo] Running text package tests ...
> > [java] Class not found " org.apache.commons.lang.text.TextTestSuite"
> >
> > BUILD FAILED
> > C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
> >
> > Which should not be run in the 1st place...
> >
> > (Ant 1.6.4 and Java 1.4.2_08)
> >
> > Gary
> >
> > -----Original Message-----
> > From: Steven Caswell [mailto:[hidden email]]
> > Sent: Tuesday, May 24, 2005 5:39 PM
> > To: Jakarta Commons Developers List
> > Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
> >
> > All,
> >
> > I have discovered a group of tests in the DateUtils test case that fails
> >
> > under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> > method
> > when rounding a date in the MET timezone across the start and end of
> > DST. If
> > I remember correctly, this was in response to a user bug report. In
> > particular the test is at line 472 of the testRound method in
> > DataUtilsTest.java.
> >
> > The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
> >
> > have a 1.3 installation available so I don't know if it passes or fails
> > under 1.3.
> >
> > I propose that we put a condition around the test so that is only run
> > when
> > the Java version is 1.4, and add a note to the round method javadoc and
> > the
> > release notes stating that the round method may not work properly in all
> >
> > cases involving DST rollovers in previous JVMs, with this case as an
> > example.
> >
> > Thoughs?
> >
> > --
> > Steven Caswell
> > [hidden email]
> >
> > Take back the web - http://www.mozilla.org
> >
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>



--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Steven:

 

(You're welcome.)

 

Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
clean dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.

 

On Sun Java 1.3.1_14 I get:

 

test.lang:

     [echo] Running lang package tests ...

     [java] Class not found "org.apache.commons.lang.LangTestSuite"

 

BUILD FAILED

C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1

 

Which makes no sense at first glance.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 7:00 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
are modified. I was just too lazy to change it to RC7 for a minor
non-code fix, and since there will probably be an RC7 with the date
utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email] > wrote:

Gary,

I have a fix for that problem. I'll go ahead and put up a corrected
source distribution with the fix and without the DateUtilsTest
correction so you can try 1.3.1.





On 5/24/05, Gary Gregory <[hidden email] > wrote:

I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "
org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 

Reply | Threaded
Open this post in threaded view
|

FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Steven:

 

I updated from CVS today and got new build.xml. I still get the error
below on Sun Java 1.3.1_14.

 

Thanks,

Gary

 

________________________________

From: Gary Gregory
Sent: Tuesday, May 24, 2005 7:12 PM
To: 'Steven Caswell'
Cc: Jakarta Commons Developers List
Subject: RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Steven:

 

(You're welcome.)

 

Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
clean dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.

 

On Sun Java 1.3.1_14 I get:

 

test.lang:

     [echo] Running lang package tests ...

     [java] Class not found "org.apache.commons.lang.LangTestSuite"

 

BUILD FAILED

C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1

 

Which makes no sense at first glance.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 7:00 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
are modified. I was just too lazy to change it to RC7 for a minor
non-code fix, and since there will probably be an RC7 with the date
utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email] > wrote:

Gary,

I have a fix for that problem. I'll go ahead and put up a corrected
source distribution with the fix and without the DateUtilsTest
correction so you can try 1.3.1.

 

On 5/24/05, Gary Gregory <[hidden email] > wrote:

I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "
org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 

Reply | Threaded
Open this post in threaded view
|

Re: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
That is so very odd. I'm at a loss to explain it. I don't have access to a
system with JDK 1.3 so I'm not able to try it. Maybe someone else can try?

One thing I did find I needed to do was to change th junit version in
default.properties from 3.7 to 3.8.1. Gary, could you try making this change
and building under 1.3.1? I'm just curious to see if this makes a
difference, though I don't see why it should.

Thanks.

On 5/25/05, Gary Gregory <[hidden email]> wrote:

>
>  Steven:
>
>  I updated from CVS today and got new build.xml. I still get the error
> below on Sun Java 1.3.1_14.
>
>  Thanks,
>
> Gary
>
>   ------------------------------
>  
> *From:* Gary Gregory
> *Sent:* Tuesday, May 24, 2005 7:12 PM
> *To:* 'Steven Caswell'
> *Cc:* Jakarta Commons Developers List
> *Subject:* RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>  
>  Steven:
>
>  (You're welcome.)
>
>  Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant clean
> dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.
>
>  On Sun Java 1.3.1_14 I get:
>
>  test.lang:
>
> [echo] Running lang package tests ...
>
> [java] Class not found "org.apache.commons.lang.LangTestSuite"
>
>  BUILD FAILED
>
> C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1
>
>  Which makes no sense at first glance.
>
>  Gary
>
>   ------------------------------
>  
> *From:* Steven Caswell [mailto:[hidden email]]
> *Sent:* Tuesday, May 24, 2005 7:00 PM
> *To:* Gary Gregory
> *Cc:* Jakarta Commons Developers List
> *Subject:* Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>  
>  Gary,
>
> I put up the revised source distribution in
> http://www.apache.org/~stevencaswell/commons-lang-2.1<http://www.apache.org/%7Estevencaswell/commons-lang-2.1>
>
> I named them commons-lang-2.1-RC6a-src.* so you could easily tell they are
> modified. I was just too lazy to change it to RC7 for a minor non-code fix,
> and since there will probably be an RC7 with the date utils test change.
>
> Thanks for your patience and thanks for testing these things.
>  
> On 5/24/05, *Steven Caswell* <[hidden email] > wrote:
>
> Gary,
>
> I have a fix for that problem. I'll go ahead and put up a corrected source
> distribution with the fix and without the DateUtilsTest correction so you
> can try 1.3.1.
>  
>  On 5/24/05, *Gary Gregory* <[hidden email] > wrote:
>
> I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> from src-zip does not make it past text tests:
>
> test.text:
> [echo] Running text package tests ...
> [java] Class not found " org.apache.commons.lang.text.TextTestSuite"
>
> BUILD FAILED
> C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
>
> Which should not be run in the 1st place...
>
> (Ant 1.6.4 and Java 1.4.2_08)
>
> Gary
>
> -----Original Message-----
> From: Steven Caswell [mailto:[hidden email]]
> Sent: Tuesday, May 24, 2005 5:39 PM
> To: Jakarta Commons Developers List
> Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>
> All,
>
> I have discovered a group of tests in the DateUtils test case that fails
>
> under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> method
> when rounding a date in the MET timezone across the start and end of
> DST. If
> I remember correctly, this was in response to a user bug report. In
> particular the test is at line 472 of the testRound method in
> DataUtilsTest.java.
>
> The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
>
> have a 1.3 installation available so I don't know if it passes or fails
> under 1.3.
>
> I propose that we put a condition around the test so that is only run
> when
> the Java version is 1.4, and add a note to the round method javadoc and
> the
> release notes stating that the round method may not work properly in all
>
> cases involving DST rollovers in previous JVMs, with this case as an
> example.
>
> Thoughs?
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org
>  
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>  
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>  



--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

RE: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Hi:

 

I found possible solution. With 1.3.1, if I set fork to false, the test
is found and run. Weird.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 5:06 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

 

That is so very odd. I'm at a loss to explain it. I don't have access to
a system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

One thing I did find I needed to do was to change th junit version in
default.properties from 3.7 to 3.8.1. Gary, could you try making this
change and building under 1.3.1? I'm just curious to see if this makes a
difference, though I don't see why it should.

Thanks.

On 5/25/05, Gary Gregory <[hidden email]> wrote:

Steven:

 

I updated from CVS today and got new build.xml. I still get the error
below on Sun Java 1.3.1_14.

 

Thanks,

Gary

 

________________________________

From: Gary Gregory
Sent: Tuesday, May 24, 2005 7:12 PM
To: 'Steven Caswell'
Cc: Jakarta Commons Developers List
Subject: RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Steven:

 

(You're welcome.)

 

Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
clean dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.

 

On Sun Java 1.3.1_14 I get:

 

test.lang:

     [echo] Running lang package tests ...

     [java] Class not found "org.apache.commons.lang.LangTestSuite"

 

BUILD FAILED

C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1

 

Which makes no sense at first glance.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 7:00 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1
<http://www.apache.org/%7Estevencaswell/commons-lang-2.1>

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
are modified. I was just too lazy to change it to RC7 for a minor
non-code fix, and since there will probably be an RC7 with the date
utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email] > wrote:

Gary,

I have a fix for that problem. I'll go ahead and put up a corrected
source distribution with the fix and without the DateUtilsTest
correction so you can try 1.3.1.

 

On 5/24/05, Gary Gregory <[hidden email] > wrote:

I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "
org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 

Reply | Threaded
Open this post in threaded view
|

RE: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
As a minor clean up facilitating debugging, I've refactored the unit
test fork attribute in a default.properties property named "test.fork",
the default is true, as in the build.xml file.

Gary

-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 5:37 PM
To: Steven Caswell
Cc: Jakarta Commons Developers List
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Hi:

 

I found possible solution. With 1.3.1, if I set fork to false, the test
is found and run. Weird.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 5:06 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

 

That is so very odd. I'm at a loss to explain it. I don't have access to
a system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

One thing I did find I needed to do was to change th junit version in
default.properties from 3.7 to 3.8.1. Gary, could you try making this
change and building under 1.3.1? I'm just curious to see if this makes a
difference, though I don't see why it should.

Thanks.

On 5/25/05, Gary Gregory <[hidden email]> wrote:

Steven:

 

I updated from CVS today and got new build.xml. I still get the error
below on Sun Java 1.3.1_14.

 

Thanks,

Gary

 

________________________________

From: Gary Gregory
Sent: Tuesday, May 24, 2005 7:12 PM
To: 'Steven Caswell'
Cc: Jakarta Commons Developers List
Subject: RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Steven:

 

(You're welcome.)

 

Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
clean dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.

 

On Sun Java 1.3.1_14 I get:

 

test.lang:

     [echo] Running lang package tests ...

     [java] Class not found "org.apache.commons.lang.LangTestSuite"

 

BUILD FAILED

C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1

 

Which makes no sense at first glance.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 7:00 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1
<http://www.apache.org/%7Estevencaswell/commons-lang-2.1>

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
are modified. I was just too lazy to change it to RC7 for a minor
non-code fix, and since there will probably be an RC7 with the date
utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email] > wrote:

Gary,

I have a fix for that problem. I'll go ahead and put up a corrected
source distribution with the fix and without the DateUtilsTest
correction so you can try 1.3.1.

 

On 5/24/05, Gary Gregory <[hidden email] > wrote:

I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "
org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Simon Kitching
In reply to this post by Steven Caswell
Hi,

====
with lang/trunk:
"maven clean test" works for me with java1.5 on linux
"ant clean dist-build-2.1 test" works for me with java1.5 on linux

with the contents of file commons-lang-2.1-RC6a-src.tar.gz:
"maven clean test" works for me with java1.5 on linux
"ant clean dist-build-2.1 test" works for me with java1.5 on linux

I used junit-3.8.1 with ant.

====
"maven clean test" on lang/trunk or with the download RC6a file fails
with java1.3.1 on linux:
 [junit] Tests run: 40, Failures: 1, Errors: 0, Time elapsed: 4.995 sec
 [junit] [ERROR] TEST org.apache.commons.lang.time.TimeTestSuite FAILED

$ cat target/test-reports/
  TEST-org.apache.commons.lang.time.TimeTestSuite.txt

Testcase: testRound(org.apache.commons.lang.time.DateUtilsTest):
FAILED
round MET date across DST change-over expected:<Sun Mar 30 03:00:00 IRST
2003> but was:<Sun Mar 30 02:00:00 IRST 2003>
junit.framework.AssertionFailedError: round MET date across DST
change-over expected:<Sun Mar 30 03:00:00 IRST 2003> but was:<Sun Mar 30
02:00:00 IRST 2003>
        at
org.apache.commons.lang.time.DateUtilsTest.testRound(DateUtilsTest.java:472)

$ java -version
java version "1.3.1_14"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.1_14-b03)
Java HotSpot(TM) Client VM (build 1.3.1_14-b03, mixed mode)
====

I did not get the reported problem:
> [java] Class not found "org.apache.commons.lang.LangTestSuite"

====

I don't see any RC6 directory under lang/tags. I presume the .tar.gz
file on your site is actually from HEAD?

====

Regards,

Simon

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:

> That is so very odd. I'm at a loss to explain it. I don't have access to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can try?
>
> One thing I did find I needed to do was to change th junit version in
> default.properties from 3.7 to 3.8.1. Gary, could you try making this change
> and building under 1.3.1? I'm just curious to see if this makes a
> difference, though I don't see why it should.
>
> Thanks.
>
> On 5/25/05, Gary Gregory <[hidden email]> wrote:
> >
> >  Steven:
> >
> >  I updated from CVS today and got new build.xml. I still get the error
> > below on Sun Java 1.3.1_14.
> >
> >  Thanks,
> >
> > Gary
> >
> >   ------------------------------
> >  
> > *From:* Gary Gregory
> > *Sent:* Tuesday, May 24, 2005 7:12 PM
> > *To:* 'Steven Caswell'
> > *Cc:* Jakarta Commons Developers List
> > *Subject:* RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
> >  
> >  Steven:
> >
> >  (You're welcome.)
> >
> >  Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant clean
> > dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.
> >
> >  On Sun Java 1.3.1_14 I get:
> >
> >  test.lang:
> >
> > [echo] Running lang package tests ...
> >
> > [java] Class not found "org.apache.commons.lang.LangTestSuite"
> >
> >  BUILD FAILED
> >
> > C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1
> >
> >  Which makes no sense at first glance.
> >
> >  Gary
> >
> >   ------------------------------
> >  
> > *From:* Steven Caswell [mailto:[hidden email]]
> > *Sent:* Tuesday, May 24, 2005 7:00 PM
> > *To:* Gary Gregory
> > *Cc:* Jakarta Commons Developers List
> > *Subject:* Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
> >  
> >  Gary,
> >
> > I put up the revised source distribution in
> > http://www.apache.org/~stevencaswell/commons-lang-2.1<http://www.apache.org/%7Estevencaswell/commons-lang-2.1>
> >
> > I named them commons-lang-2.1-RC6a-src.* so you could easily tell they are
> > modified. I was just too lazy to change it to RC7 for a minor non-code fix,
> > and since there will probably be an RC7 with the date utils test change.
> >
> > Thanks for your patience and thanks for testing these things.
> >  
> > On 5/24/05, *Steven Caswell* <[hidden email] > wrote:
> >
> > Gary,
> >
> > I have a fix for that problem. I'll go ahead and put up a corrected source
> > distribution with the fix and without the DateUtilsTest correction so you
> > can try 1.3.1.
> >  
> >  On 5/24/05, *Gary Gregory* <[hidden email] > wrote:
> >
> > I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> > from src-zip does not make it past text tests:
> >
> > test.text:
> > [echo] Running text package tests ...
> > [java] Class not found " org.apache.commons.lang.text.TextTestSuite"
> >
> > BUILD FAILED
> > C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
> >
> > Which should not be run in the 1st place...
> >
> > (Ant 1.6.4 and Java 1.4.2_08)
> >
> > Gary
> >
> > -----Original Message-----
> > From: Steven Caswell [mailto:[hidden email]]
> > Sent: Tuesday, May 24, 2005 5:39 PM
> > To: Jakarta Commons Developers List
> > Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
> >
> > All,
> >
> > I have discovered a group of tests in the DateUtils test case that fails
> >
> > under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> > method
> > when rounding a date in the MET timezone across the start and end of
> > DST. If
> > I remember correctly, this was in response to a user bug report. In
> > particular the test is at line 472 of the testRound method in
> > DataUtilsTest.java.
> >
> > The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
> >
> > have a 1.3 installation available so I don't know if it passes or fails
> > under 1.3.
> >
> > I propose that we put a condition around the test so that is only run
> > when
> > the Java version is 1.4, and add a note to the round method javadoc and
> > the
> > release notes stating that the round method may not work properly in all
> >
> > cases involving DST rollovers in previous JVMs, with this case as an
> > example.
> >
> > Thoughs?
> >
> > --
> > Steven Caswell
> > [hidden email]
> >
> > Take back the web - http://www.mozilla.org
> >  
> >
> >
> >
> > --
> > Steven Caswell
> > [hidden email]
> >
> > Take back the web - http://www.mozilla.org 
> >  
> >
> >
> >
> > --
> > Steven Caswell
> > [hidden email]
> >
> > Take back the web - http://www.mozilla.org 
> >  
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
In reply to this post by Gary Gregory
Glad you found it.

On 5/26/05, Gary Gregory <[hidden email]> wrote:

>
>  Hi:
>
>  I found possible solution. With 1.3.1, if I set *fork* to *false*, the
> test is found and run. Weird.
>
>  Gary
>
>   ------------------------------
>  
> *From:* Steven Caswell [mailto:[hidden email]]
> *Sent:* Thursday, May 26, 2005 5:06 PM
> *To:* Gary Gregory
> *Cc:* Jakarta Commons Developers List
> *Subject:* Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
>  
>  That is so very odd. I'm at a loss to explain it. I don't have access to
> a system with JDK 1.3 so I'm not able to try it. Maybe someone else can
> try?
>
> One thing I did find I needed to do was to change th junit version in
> default.properties from 3.7 to 3.8.1. Gary, could you try making this
> change and building under 1.3.1? I'm just curious to see if this makes a
> difference, though I don't see why it should.
>
> Thanks.
>  
> On 5/25/05, *Gary Gregory* <[hidden email]> wrote:
>  
> Steven:
>
>  I updated from CVS today and got new build.xml. I still get the error
> below on Sun Java 1.3.1_14.
>
>  Thanks,
>
> Gary
>
>   ------------------------------
>  
> *From:* Gary Gregory
> *Sent:* Tuesday, May 24, 2005 7:12 PM
> *To:* 'Steven Caswell'
> *Cc:* Jakarta Commons Developers List
> *Subject:* RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>  
>  Steven:
>
>  (You're welcome.)
>
>  Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant clean
> dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.
>
>  On Sun Java 1.3.1_14 I get:
>
>  test.lang:
>
> [echo] Running lang package tests ...
>
> [java] Class not found "org.apache.commons.lang.LangTestSuite"
>
>  BUILD FAILED
>
> C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1
>
>  Which makes no sense at first glance.
>
>  Gary
>
>   ------------------------------
>  
> *From:* Steven Caswell [mailto:[hidden email]]
> *Sent:* Tuesday, May 24, 2005 7:00 PM
> *To:* Gary Gregory
> *Cc:* Jakarta Commons Developers List
> *Subject:* Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>  
>  Gary,
>
> I put up the revised source distribution in http://www.apache.org/~stevencaswell/commons-lang-2.1 
> <http://www.apache.org/%7Estevencaswell/commons-lang-2.1>
>
> I named them commons-lang-2.1-RC6a-src.* so you could easily tell they are
> modified. I was just too lazy to change it to RC7 for a minor non-code fix,
> and since there will probably be an RC7 with the date utils test change.
>
> Thanks for your patience and thanks for testing these things.
>  
> On 5/24/05, *Steven Caswell* <[hidden email] > wrote:
>
> Gary,
>
> I have a fix for that problem. I'll go ahead and put up a corrected source
> distribution with the fix and without the DateUtilsTest correction so you
> can try 1.3.1.
>  
>  On 5/24/05, *Gary Gregory* <[hidden email] > wrote:
>
> I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> from src-zip does not make it past text tests:
>
> test.text:
> [echo] Running text package tests ...
> [java] Class not found " org.apache.commons.lang.text.TextTestSuite"
>
> BUILD FAILED
> C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
>
> Which should not be run in the 1st place...
>
> (Ant 1.6.4 and Java 1.4.2_08)
>
> Gary
>
> -----Original Message-----
> From: Steven Caswell [mailto:[hidden email]]
> Sent: Tuesday, May 24, 2005 5:39 PM
> To: Jakarta Commons Developers List
> Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
>
> All,
>
> I have discovered a group of tests in the DateUtils test case that fails
>
> under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> method
> when rounding a date in the MET timezone across the start and end of
> DST. If
> I remember correctly, this was in response to a user bug report. In
> particular the test is at line 472 of the testRound method in
> DataUtilsTest.java.
>
> The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't
>
> have a 1.3 installation available so I don't know if it passes or fails
> under 1.3.
>
> I propose that we put a condition around the test so that is only run
> when
> the Java version is 1.4, and add a note to the round method javadoc and
> the
> release notes stating that the round method may not work properly in all
>
> cases involving DST rollovers in previous JVMs, with this case as an
> example.
>
> Thoughs?
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org
>  
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>  
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>  
>
>
>
> --
> Steven Caswell
> [hidden email]
>
> Take back the web - http://www.mozilla.org 
>  



--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

Re: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Steven Caswell
In reply to this post by Simon Kitching
Simon,

Thanks for the tests. Glad to hear 1.5 is clean.

I found the same errors with the DateUtilsTest and I've got a fix ready to
check in. I was waiting until we resolved these other issues.

There is a tag for RC6 but not for the RC6a because I built it from the head
and from a couple of local changes. I plan to build an RC7 with the test
source and configuration fixes and cross my fingers that it will be the
golden one.


On 5/26/05, Simon Kitching <[hidden email]> wrote:

>
> Hi,
>
> ====
> with lang/trunk:
> "maven clean test" works for me with java1.5 on linux
> "ant clean dist-build-2.1 test" works for me with java1.5 on linux
>
> with the contents of file commons-lang-2.1-RC6a-src.tar.gz:
> "maven clean test" works for me with java1.5 on linux
> "ant clean dist-build-2.1 test" works for me with java1.5 on linux
>
> I used junit-3.8.1 with ant.
>
> ====
> "maven clean test" on lang/trunk or with the download RC6a file fails
> with java1.3.1 on linux:
> [junit] Tests run: 40, Failures: 1, Errors: 0, Time elapsed: 4.995 sec
> [junit] [ERROR] TEST org.apache.commons.lang.time.TimeTestSuite FAILED
>
> $ cat target/test-reports/
> TEST-org.apache.commons.lang.time.TimeTestSuite.txt
>
> Testcase: testRound(org.apache.commons.lang.time.DateUtilsTest):
> FAILED
> round MET date across DST change-over expected:<Sun Mar 30 03:00:00 IRST
> 2003> but was:<Sun Mar 30 02:00:00 IRST 2003>
> junit.framework.AssertionFailedError: round MET date across DST
> change-over expected:<Sun Mar 30 03:00:00 IRST 2003> but was:<Sun Mar 30
> 02:00:00 IRST 2003>
> at
> org.apache.commons.lang.time.DateUtilsTest.testRound(DateUtilsTest.java
> :472)
>
> $ java -version
> java version "1.3.1_14"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.1_14-b03)
> Java HotSpot(TM) Client VM (build 1.3.1_14-b03, mixed mode)
> ====
>
> I did not get the reported problem:
> > [java] Class not found "org.apache.commons.lang.LangTestSuite"
>
> ====
>
> I don't see any RC6 directory under lang/tags. I presume the .tar.gz
> file on your site is actually from HEAD?
>
> ====
>
> Regards,
>
> Simon
>
> On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> > That is so very odd. I'm at a loss to explain it. I don't have access to
> a
> > system with JDK 1.3 so I'm not able to try it. Maybe someone else can
> try?
> >
> > One thing I did find I needed to do was to change th junit version in
> > default.properties from 3.7 to 3.8.1. Gary, could you try making this
> change
> > and building under 1.3.1? I'm just curious to see if this makes a
> > difference, though I don't see why it should.
> >
> > Thanks.
> >
> > On 5/25/05, Gary Gregory <[hidden email]> wrote:
> > >
> > > Steven:
> > >
> > > I updated from CVS today and got new build.xml. I still get the error
> > > below on Sun Java 1.3.1_14.
> > >
> > > Thanks,
> > >
> > > Gary
> > >
> > > ------------------------------
> > >
> > > *From:* Gary Gregory
> > > *Sent:* Tuesday, May 24, 2005 7:12 PM
> > > *To:* 'Steven Caswell'
> > > *Cc:* Jakarta Commons Developers List
> > > *Subject:* RE: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
> > >
> > > Steven:
> > >
> > > (You're welcome.)
> > >
> > > Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
> clean
> > > dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.
> > >
> > > On Sun Java 1.3.1_14 I get:
> > >
> > > test.lang:
> > >
> > > [echo] Running lang package tests ...
> > >
> > > [java] Class not found "org.apache.commons.lang.LangTestSuite"
> > >
> > > BUILD FAILED
> > >
> > > C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1
> > >
> > > Which makes no sense at first glance.
> > >
> > > Gary
> > >
> > > ------------------------------
> > >
> > > *From:* Steven Caswell [mailto:[hidden email]]
> > > *Sent:* Tuesday, May 24, 2005 7:00 PM
> > > *To:* Gary Gregory
> > > *Cc:* Jakarta Commons Developers List
> > > *Subject:* Re: [lang] DateUtils test fails under 1.2.2 and not under
> 1.4.2
> > >
> > > Gary,
> > >
> > > I put up the revised source distribution in
> > > http://www.apache.org/~stevencaswell/commons-lang-2.1<
> http://www.apache.org/%7Estevencaswell/commons-lang-2.1>
> > >
> > > I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
> are
> > > modified. I was just too lazy to change it to RC7 for a minor non-code
> fix,
> > > and since there will probably be an RC7 with the date utils test
> change.
> > >
> > > Thanks for your patience and thanks for testing these things.
> > >
> > > On 5/24/05, *Steven Caswell* <[hidden email] > wrote:
> > >
> > > Gary,
> > >
> > > I have a fix for that problem. I'll go ahead and put up a corrected
> source
> > > distribution with the fix and without the DateUtilsTest correction so
> you
> > > can try 1.3.1.
> > >
> > > On 5/24/05, *Gary Gregory* <[hidden email] > wrote:
> > >
> > > I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
> > > from src-zip does not make it past text tests:
> > >
> > > test.text:
> > > [echo] Running text package tests ...
> > > [java] Class not found " org.apache.commons.lang.text.TextTestSuite"
> > >
> > > BUILD FAILED
> > > C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1
> > >
> > > Which should not be run in the 1st place...
> > >
> > > (Ant 1.6.4 and Java 1.4.2_08)
> > >
> > > Gary
> > >
> > > -----Original Message-----
> > > From: Steven Caswell [mailto:[hidden email]]
> > > Sent: Tuesday, May 24, 2005 5:39 PM
> > > To: Jakarta Commons Developers List
> > > Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2
> > >
> > > All,
> > >
> > > I have discovered a group of tests in the DateUtils test case that
> fails
> > >
> > > under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
> > > method
> > > when rounding a date in the MET timezone across the start and end of
> > > DST. If
> > > I remember correctly, this was in response to a user bug report. In
> > > particular the test is at line 472 of the testRound method in
> > > DataUtilsTest.java.
> > >
> > > The test passes fine when run under 1.4.2 but fails under 1.2.2. I
> don't
> > >
> > > have a 1.3 installation available so I don't know if it passes or
> fails
> > > under 1.3.
> > >
> > > I propose that we put a condition around the test so that is only run
> > > when
> > > the Java version is 1.4, and add a note to the round method javadoc
> and
> > > the
> > > release notes stating that the round method may not work properly in
> all
> > >
> > > cases involving DST rollovers in previous JVMs, with this case as an
> > > example.
> > >
> > > Thoughs?
> > >
> > > --
> > > Steven Caswell
> > > [hidden email]
> > >
> > > Take back the web - http://www.mozilla.org
> > >
> > >
> > >
> > >
> > > --
> > > Steven Caswell
> > > [hidden email]
> > >
> > > Take back the web - http://www.mozilla.org
> > >
> > >
> > >
> > >
> > > --
> > > Steven Caswell
> > > [hidden email]
> > >
> > > Take back the web - http://www.mozilla.org
> > >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org
Reply | Threaded
Open this post in threaded view
|

RE: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Well, it is not a real solution, just a data point in finding out what
is wrong. I'll keep looking tomorrow.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 6:02 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

 

Glad you found it.

On 5/26/05, Gary Gregory <[hidden email]> wrote:

Hi:

 

I found possible solution. With 1.3.1, if I set fork to false, the test
is found and run. Weird.

 

Gary

 

________________________________

From: Steven Caswell [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 5:06 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

 

That is so very odd. I'm at a loss to explain it. I don't have access to
a system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

One thing I did find I needed to do was to change th junit version in
default.properties from 3.7 to 3.8.1. Gary, could you try making this
change and building under 1.3.1? I'm just curious to see if this makes a
difference, though I don't see why it should.

Thanks.

On 5/25/05, Gary Gregory <[hidden email]> wrote:

Steven:

 

I updated from CVS today and got new build.xml. I still get the error
below on Sun Java 1.3.1_14.

 

Thanks,

Gary

 

________________________________

From: Gary Gregory
Sent: Tuesday, May 24, 2005 7:12 PM
To: 'Steven Caswell'
Cc: Jakarta Commons Developers List
Subject: RE: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Steven:

 

(You're welcome.)

 

Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant
clean dist-build-2.1 test" which works fine on Sun Java 1.4.2_08.

 

On Sun Java 1.3.1_14 I get:

 

test.lang:

     [echo] Running lang package tests ...

     [java] Class not found "org.apache.commons.lang.LangTestSuite"

 

BUILD FAILED

C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1

 

Which makes no sense at first glance.

 

Gary

 

________________________________

From: Steven Caswell [mailto: [hidden email]]
Sent: Tuesday, May 24, 2005 7:00 PM
To: Gary Gregory
Cc: Jakarta Commons Developers List
Subject: Re: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

 

Gary,

I put up the revised source distribution in
http://www.apache.org/~stevencaswell/commons-lang-2.1
<http://www.apache.org/%7Estevencaswell/commons-lang-2.1>

I named them commons-lang-2.1-RC6a-src.* so you could easily tell they
are modified. I was just too lazy to change it to RC7 for a minor
non-code fix, and since there will probably be an RC7 with the date
utils test change.

Thanks for your patience and thanks for testing these things.

On 5/24/05, Steven Caswell <[hidden email] > wrote:

Gary,

I have a fix for that problem. I'll go ahead and put up a corrected
source distribution with the fix and without the DateUtilsTest
correction so you can try 1.3.1.

 

On 5/24/05, Gary Gregory <[hidden email] > wrote:

I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test"
from src-zip does not make it past text tests:

test.text:
     [echo] Running text package tests ...
     [java] Class not found "
org.apache.commons.lang.text.TextTestSuite"

BUILD FAILED
C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1

Which should not be run in the 1st place...

(Ant 1.6.4 and Java 1.4.2_08)

Gary

-----Original Message-----
From: Steven Caswell [mailto:[hidden email]]
Sent: Tuesday, May 24, 2005 5:39 PM
To: Jakarta Commons Developers List
Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

All,

I have discovered a group of tests in the DateUtils test case that fails

under 1.2.2 but not under 1.4.2. They are testing the DateUtils round
method
when rounding a date in the MET timezone across the start and end of
DST. If
I remember correctly, this was in response to a user bug report. In
particular the test is at line 472 of the testRound method in
DataUtilsTest.java.

The test passes fine when run under 1.4.2 but fails under 1.2.2. I don't

have a 1.3 installation available so I don't know if it passes or fails
under 1.3.

I propose that we put a condition around the test so that is only run
when
the Java version is 1.4, and add a note to the round method javadoc and
the
release notes stating that the round method may not work properly in all

cases involving DST rollovers in previous JVMs, with this case as an
example.

Thoughs?

--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 




--
Steven Caswell
[hidden email]

Take back the web - http://www.mozilla.org 

Reply | Threaded
Open this post in threaded view
|

Re: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Simon Kitching
In reply to this post by Steven Caswell
On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Hello Steven and All:

Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.

Instead of using this odd way of invoking unit tests:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <java classname="${test.runner}" fork="${test.fork}"
failonerror="${test.failonerror}">
            <arg value="org.apache.commons.lang.LangTestSuite"/>
            <classpath refid="test.classpath"/>
        </java>
    </target>

I changed this target on my machine to the more standard JUnit
invocation:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
            <classpath refid="test.classpath"/>
            <test name="org.apache.commons.lang.LangTestSuite"/>
        </junit>
    </target>

The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.

Shall I (or Steven) change the JUnit invocation style for all tests?

Gary

-----Original Message-----
From: Simon Kitching [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 9:07 PM
To: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access
to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: FW: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2

Gary Gregory
In reply to this post by Steven Caswell
Actually, assuming what is below is acceptable, using Ant 1.6 allows for
a clean up to make the build.xml file shorter with:

    <macrodef name="testit">
        <attribute name="classname"/>
        <sequential>
            <junit printsummary="true" fork="${junit.fork}"
haltonerror="${test.failonerror}">
                <classpath refid="test.classpath"/>
                <test name="@{classname}"/>
            </junit>
        </sequential>
    </macrodef>

    <target name="test.lang" depends="compile.tests">
        <testit classname="org.apache.commons.lang.LangTestSuite"/>
    </target>

    <!-- Ditto for all test targets. -->

Any thoughts on making Ant 1.6 a build pre-req?

Gary

-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 10:56 PM
To: Jakarta Commons Developers List; [hidden email]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Hello Steven and All:

Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.

Instead of using this odd way of invoking unit tests:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <java classname="${test.runner}" fork="${test.fork}"
failonerror="${test.failonerror}">
            <arg value="org.apache.commons.lang.LangTestSuite"/>
            <classpath refid="test.classpath"/>
        </java>
    </target>

I changed this target on my machine to the more standard JUnit
invocation:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
            <classpath refid="test.classpath"/>
            <test name="org.apache.commons.lang.LangTestSuite"/>
        </junit>
    </target>

The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.

Shall I (or Steven) change the JUnit invocation style for all tests?

Gary

-----Original Message-----
From: Simon Kitching [mailto:[hidden email]]
Sent: Thursday, May 26, 2005 9:07 PM
To: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access
to a
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]