[lang] LANG-1442

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[lang] LANG-1442

Rob Tompkins
Reply | Threaded
Open this post in threaded view
|

Re: [lang] LANG-1442

Benedikt Ritter-4
LGTM

Am Sa., 6. Apr. 2019 um 16:59 Uhr schrieb Rob Tompkins <[hidden email]>:

> @Gilles - thoughts on this wording:
> https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442
> <
> https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442>
> ?
>
> -Rob
Reply | Threaded
Open this post in threaded view
|

Re: [lang] LANG-1442

Gilles Sadowski-2
In reply to this post by Rob Tompkins
Le sam. 6 avr. 2019 à 16:59, Rob Tompkins <[hidden email]> a écrit :
>
> @Gilles - thoughts on this wording: https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442 <https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442> ?

There is a typo "the user use" -> "the user uses".
Otherwise seems fair, but I'd suggest being assertive:
 * "We would like to further note to users" -> "Please note that [...]"
 * "For a more extensive treatment of random numbers" -> "For more
stringent requirements (performance and/or correctness) [...]"

That would give concrete hints that there is more to it than it looks.

Thus, how about inserting this paragraph:
---
 * <p>Please note that the Apache Commons project provides a component
 * dedicated to pseudo-random number generation, namely
 * <a href="https://commons.apache.org/rng">Commons RNG</a>, that may be
 * a better choice for applications with more stringent requirements
(performance
 * and/or correctness).</p>
---
?

Regards,
Gilles

>
> -Rob

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lang] LANG-1442

sebb-2-2
On Sat, 6 Apr 2019 at 17:18, Gilles Sadowski <[hidden email]> wrote:
>
> Le sam. 6 avr. 2019 à 16:59, Rob Tompkins <[hidden email]> a écrit :
> >
> > @Gilles - thoughts on this wording: https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442 <https://github.com/apache/commons-lang/commit/3f43706192b1b75c5023f165534a12b192c31442> ?
>
> There is a typo "the user use" -> "the user uses".

Note that 'suggest that' is a subjunctive, for which 'use' is usually
considered more correct [1]

However neither reads well to me.

> Otherwise seems fair, but I'd suggest being assertive:

Agreed.

>  * "We would like to further note to users" -> "Please note that [...]"
>  * "For a more extensive treatment of random numbers" -> "For more
> stringent requirements (performance and/or correctness) [...]"
>
> That would give concrete hints that there is more to it than it looks.
>
> Thus, how about inserting this paragraph:
> ---
>  * <p>Please note that the Apache Commons project provides a component
>  * dedicated to pseudo-random number generation, namely
>  * <a href="https://commons.apache.org/rng">Commons RNG</a>, that may be
>  * a better choice for applications with more stringent requirements
> (performance
>  * and/or correctness).</p>
> ---
> ?

That reads better.

Note: I still think we should stop short of making recommendations
regarding cryptographically secure RNGs here.
So the previous sentence "Consider instead ..." needs be dropped.

S.
[1] https://grammarist.com/grammar/subjunctive-mood/
Note: 'I suggest that he implement a ...'

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]