[lang] Why have a HashSetvBitSetTest?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[lang] Why have a HashSetvBitSetTest?

Allon Mureinik
Hi all,

Building commons-lang locally made me notice HashSetvBitSetTest, which made
me wonder why we need it as a unit test.

I'm guessing it was originally used to support a design decision about
which data structure to use. But having done it, we now have  a relatively
slow test (on my machine - 0.582 seconds out of a total seconds it takes to
mvn test ~ 2.1%), which prints to stdout, and doesn't test any
functionality of the code provided in commons-lang.

Wouldn't it make more sense to @Ignore this test and just run it when a new
jvm/jdk is tested? or even remove it completely?


-Allon
Reply | Threaded
Open this post in threaded view
|

Re: [lang] Why have a HashSetvBitSetTest?

Pascal Schumacher
Hi Allon,

there is this issue: https://issues.apache.org/jira/browse/LANG-1110 and
this pull request: https://github.com/apache/commons-lang/pull/182 which
plan to convert the test to a JMH based benchmark.

I think the plan was to merge the pull request soon. If that does not
happen, I'm +1 to ignoring the test.

Cheers,
Pascal

Am 25.02.2017 um 09:51 schrieb Allon Mureinik:

> Hi all,
>
> Building commons-lang locally made me notice HashSetvBitSetTest, which made
> me wonder why we need it as a unit test.
>
> I'm guessing it was originally used to support a design decision about
> which data structure to use. But having done it, we now have  a relatively
> slow test (on my machine - 0.582 seconds out of a total seconds it takes to
> mvn test ~ 2.1%), which prints to stdout, and doesn't test any
> functionality of the code provided in commons-lang.
>
> Wouldn't it make more sense to @Ignore this test and just run it when a new
> jvm/jdk is tested? or even remove it completely?
>
>
> -Allon
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]