[math] github pull requests

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[math] github pull requests

Luc Maisonobe-2
Hi all,

As the github pull request are not forwarded here, there are two new
requests since yesterday:

  <https://github.com/apache/commons-math/pull/11>
  <https://github.com/apache/commons-math/pull/12>

What do you think about them?

Luc

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [math] github pull requests

Gilles Sadowski
Hello.

On Tue, 25 Aug 2015 15:29:37 +0200, Luc Maisonobe wrote:
> Hi all,
>
> As the github pull request are not forwarded here, there are two new
> requests since yesterday:
>
>   <https://github.com/apache/commons-math/pull/11>

I don't understand that one.

>   <https://github.com/apache/commons-math/pull/12>

I'd rather not start adding methods that handle "Double[]" args.

If the feature is deemed useful, we could add a utility in
"MathArrays":
---CUT---
   public double[] convert(Double[] a) { /* ... */ }
---CUT---

But I'd think that it is more of a "Lang" feature.


Best reagards,
Gilles

>
> What do you think about them?
>
> Luc


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [math] github pull requests

Stefan Bodewig
In reply to this post by Luc Maisonobe-2
On 2015-08-25, Luc Maisonobe wrote:

> As the github pull request are not forwarded here,

You know that you can enable automatic notifications?  I don't recall
the details - probably something involving a ticket for INFRA - but we
do see PR notifications in Ant for example.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [math] github pull requests

Luc Maisonobe-2
Le 25/08/2015 16:14, Stefan Bodewig a écrit :
> On 2015-08-25, Luc Maisonobe wrote:
>
>> As the github pull request are not forwarded here,
>
> You know that you can enable automatic notifications?  I don't recall
> the details - probably something involving a ticket for INFRA - but we
> do see PR notifications in Ant for example.

I am already registered, and this is how I got these PR. This is the
reason I forwarded them here so other developers are aware of them.

Luc

>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [math] github pull requests

Otmar Ertl
In reply to this post by Gilles Sadowski
On Tue, Aug 25, 2015 at 4:11 PM, Gilles <[hidden email]> wrote:

> Hello.
>
> On Tue, 25 Aug 2015 15:29:37 +0200, Luc Maisonobe wrote:
>>
>> Hi all,
>>
>> As the github pull request are not forwarded here, there are two new
>> requests since yesterday:
>>
>>   <https://github.com/apache/commons-math/pull/11>
>
>
> I don't understand that one.
>
>>   <https://github.com/apache/commons-math/pull/12>
>
>
> I'd rather not start adding methods that handle "Double[]" args.
>
> If the feature is deemed useful, we could add a utility in "MathArrays":
> ---CUT---
>   public double[] convert(Double[] a) { /* ... */ }
> ---CUT---
>
> But I'd think that it is more of a "Lang" feature.
>
>
> Best reagards,
> Gilles

I fully agree with Gilles.

Otmar

>
>
>>
>> What do you think about them?
>>
>> Luc
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [math] github pull requests

Stefan Bodewig
In reply to this post by Luc Maisonobe-2
On 2015-08-25, Luc Maisonobe wrote:

> Le 25/08/2015 16:14, Stefan Bodewig a écrit :
>> On 2015-08-25, Luc Maisonobe wrote:

>>> As the github pull request are not forwarded here,

>> You know that you can enable automatic notifications?  I don't recall
>> the details - probably something involving a ticket for INFRA - but we
>> do see PR notifications in Ant for example.

> I am already registered, and this is how I got these PR. This is the
> reason I forwarded them here so other developers are aware of them.

That's not what I meant.  ASF infra provides services that connect
github issues and PRs and our infrastructure.  This ranges from linking
JIRA issues to PRs (two-way where comments in one get replicated to the
other) to automatic notifications of the dev list.

https://blogs.apache.org/infra/entry/improved_integration_between_apache_and

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]