svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton-3
Author: niallp
Date: Thu Feb 21 09:13:27 2008
New Revision: 629875

URL: http://svn.apache.org/viewvc?rev=629875&view=rev
Log:
Attach assembly to "package" phase in "rc" profile

Modified:
    commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
==============================================================================
--- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
+++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
@@ -260,4 +260,26 @@
         <maven.compile.source>1.4</maven.compile.source>
         <maven.compile.target>1.4</maven.compile.target>
     </properties>
+
+    <profiles>
+        <profile>
+            <id>rc</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-assembly-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <goals>
+                                    <goal>attached</goal>
+                                </goals>
+                                <phase>package</phase>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
Niall,

Should this sort of thing be in the parent pom?

On 2/21/08, [hidden email] <[hidden email]> wrote:

> Author: niallp
>  Date: Thu Feb 21 09:13:27 2008
>  New Revision: 629875
>
>  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  Log:
>  Attach assembly to "package" phase in "rc" profile
>
>  Modified:
>     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>
>  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  ==============================================================================
>  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  @@ -260,4 +260,26 @@
>          <maven.compile.source>1.4</maven.compile.source>
>          <maven.compile.target>1.4</maven.compile.target>
>      </properties>
>  +
>  +    <profiles>
>  +        <profile>
>  +            <id>rc</id>
>  +            <build>
>  +                <plugins>
>  +                    <plugin>
>  +                        <artifactId>maven-assembly-plugin</artifactId>
>  +                        <executions>
>  +                            <execution>
>  +                                <goals>
>  +                                    <goal>attached</goal>
>  +                                </goals>
>  +                                <phase>package</phase>
>  +                            </execution>
>  +                        </executions>
>  +                    </plugin>
>  +                </plugins>
>  +            </build>
>  +        </profile>
>  +    </profiles>
>  +
>   </project>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
On Thu, Feb 21, 2008 at 6:59 PM, James Carman
<[hidden email]> wrote:
> Niall,
>
>  Should this sort of thing be in the parent pom?

Possibly/probably - every component should have an assembly, but not
sure if it would mess up doing pom or skin releases which don't.

Niall


>  On 2/21/08, [hidden email] <[hidden email]> wrote:
>  > Author: niallp
>  >  Date: Thu Feb 21 09:13:27 2008
>  >  New Revision: 629875
>  >
>  >  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  >  Log:
>  >  Attach assembly to "package" phase in "rc" profile
>  >
>  >  Modified:
>  >     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >
>  >  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  >  ==============================================================================
>  >  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  >  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  >  @@ -260,4 +260,26 @@
>  >          <maven.compile.source>1.4</maven.compile.source>
>  >          <maven.compile.target>1.4</maven.compile.target>
>  >      </properties>
>  >  +
>  >  +    <profiles>
>  >  +        <profile>
>  >  +            <id>rc</id>
>  >  +            <build>
>  >  +                <plugins>
>  >  +                    <plugin>
>  >  +                        <artifactId>maven-assembly-plugin</artifactId>
>  >  +                        <executions>
>  >  +                            <execution>
>  >  +                                <goals>
>  >  +                                    <goal>attached</goal>
>  >  +                                </goals>
>  >  +                                <phase>package</phase>
>  >  +                            </execution>
>  >  +                        </executions>
>  >  +                    </plugin>
>  >  +                </plugins>
>  >  +            </build>
>  >  +        </profile>
>  >  +    </profiles>
>  >  +
>  >   </project>
>  >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
On 2/21/08, Niall Pemberton <[hidden email]> wrote:
> On Thu, Feb 21, 2008 at 6:59 PM, James Carman
>  <[hidden email]> wrote:
>  > Niall,
>  >
>  >  Should this sort of thing be in the parent pom?
>
>
> Possibly/probably - every component should have an assembly, but not
>  sure if it would mess up doing pom or skin releases which don't.

But, the pom/skin sites aren't really "published" are they?  They're
not linked from the main page.  The "developer" page, I thought, was
for Joe User to refer to if they wanted to build the library on their
own.  Do we really expect Joe User to try to build our parent/build
pom libraries?

>
>  Niall
>
>
>
>  >  On 2/21/08, [hidden email] <[hidden email]> wrote:
>  >  > Author: niallp
>  >  >  Date: Thu Feb 21 09:13:27 2008
>  >  >  New Revision: 629875
>  >  >
>  >  >  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  >  >  Log:
>  >  >  Attach assembly to "package" phase in "rc" profile
>  >  >
>  >  >  Modified:
>  >  >     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >
>  >  >  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  >  >  ==============================================================================
>  >  >  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  >  >  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  >  >  @@ -260,4 +260,26 @@
>  >  >          <maven.compile.source>1.4</maven.compile.source>
>  >  >          <maven.compile.target>1.4</maven.compile.target>
>  >  >      </properties>
>  >  >  +
>  >  >  +    <profiles>
>  >  >  +        <profile>
>  >  >  +            <id>rc</id>
>  >  >  +            <build>
>  >  >  +                <plugins>
>  >  >  +                    <plugin>
>  >  >  +                        <artifactId>maven-assembly-plugin</artifactId>
>  >  >  +                        <executions>
>  >  >  +                            <execution>
>  >  >  +                                <goals>
>  >  >  +                                    <goal>attached</goal>
>  >  >  +                                </goals>
>  >  >  +                                <phase>package</phase>
>  >  >  +                            </execution>
>  >  >  +                        </executions>
>  >  >  +                    </plugin>
>  >  >  +                </plugins>
>  >  >  +            </build>
>  >  >  +        </profile>
>  >  >  +    </profiles>
>  >  >  +
>  >  >   </project>
>  >  >
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [hidden email]
>  For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
On Thu, Feb 21, 2008 at 8:25 PM, James Carman
<[hidden email]> wrote:

> On 2/21/08, Niall Pemberton <[hidden email]> wrote:
>  > On Thu, Feb 21, 2008 at 6:59 PM, James Carman
>  >  <[hidden email]> wrote:
>  >  > Niall,
>  >  >
>  >  >  Should this sort of thing be in the parent pom?
>  >
>  >
>  > Possibly/probably - every component should have an assembly, but not
>  >  sure if it would mess up doing pom or skin releases which don't.
>
>  But, the pom/skin sites aren't really "published" are they?  They're
>  not linked from the main page.  The "developer" page, I thought, was
>  for Joe User to refer to if they wanted to build the library on their
>  own.  Do we really expect Joe User to try to build our parent/build
>  pom libraries?

Sorry I don't really understand why you're referring to developer
pages and pom/skin sites? Where does that come into this?

Niall

>  >  Niall
>  >
>  >
>  >
>  >  >  On 2/21/08, [hidden email] <[hidden email]> wrote:
>  >  >  > Author: niallp
>  >  >  >  Date: Thu Feb 21 09:13:27 2008
>  >  >  >  New Revision: 629875
>  >  >  >
>  >  >  >  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  >  >  >  Log:
>  >  >  >  Attach assembly to "package" phase in "rc" profile
>  >  >  >
>  >  >  >  Modified:
>  >  >  >     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  >
>  >  >  >  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  >  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  >  >  >  ==============================================================================
>  >  >  >  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  >  >  >  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  >  >  >  @@ -260,4 +260,26 @@
>  >  >  >          <maven.compile.source>1.4</maven.compile.source>
>  >  >  >          <maven.compile.target>1.4</maven.compile.target>
>  >  >  >      </properties>
>  >  >  >  +
>  >  >  >  +    <profiles>
>  >  >  >  +        <profile>
>  >  >  >  +            <id>rc</id>
>  >  >  >  +            <build>
>  >  >  >  +                <plugins>
>  >  >  >  +                    <plugin>
>  >  >  >  +                        <artifactId>maven-assembly-plugin</artifactId>
>  >  >  >  +                        <executions>
>  >  >  >  +                            <execution>
>  >  >  >  +                                <goals>
>  >  >  >  +                                    <goal>attached</goal>
>  >  >  >  +                                </goals>
>  >  >  >  +                                <phase>package</phase>
>  >  >  >  +                            </execution>
>  >  >  >  +                        </executions>
>  >  >  >  +                    </plugin>
>  >  >  >  +                </plugins>
>  >  >  >  +            </build>
>  >  >  >  +        </profile>
>  >  >  >  +    </profiles>
>  >  >  >  +
>  >  >  >   </project>
>  >  >  >
>  >
>  >
>
>
> > ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: [hidden email]
>  >  For additional commands, e-mail: [hidden email]
>  >
>  >
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [hidden email]
>  For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
In reply to this post by Niall Pemberton
On Thu, Feb 21, 2008 at 8:15 PM, Niall Pemberton
<[hidden email]> wrote:
> On Thu, Feb 21, 2008 at 6:59 PM, James Carman
>  <[hidden email]> wrote:
>  > Niall,
>  >
>  >  Should this sort of thing be in the parent pom?
>
>  Possibly/probably - every component should have an assembly, but not
>  sure if it would mess up doing pom or skin releases which don't.

I just tried adding this to commons parent - and when I try to run
"mvn -Prc install" for commons-parent I get the following error:

[ERROR] BUILD ERROR
[INFO] Error reading assemblies: No assembly descriptors found.

Niall

>  Niall
>
>
>
>
>  >  On 2/21/08, [hidden email] <[hidden email]> wrote:
>  >  > Author: niallp
>  >  >  Date: Thu Feb 21 09:13:27 2008
>  >  >  New Revision: 629875
>  >  >
>  >  >  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  >  >  Log:
>  >  >  Attach assembly to "package" phase in "rc" profile
>  >  >
>  >  >  Modified:
>  >  >     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >
>  >  >  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  >  >  ==============================================================================
>  >  >  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  >  >  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  >  >  @@ -260,4 +260,26 @@
>  >  >          <maven.compile.source>1.4</maven.compile.source>
>  >  >          <maven.compile.target>1.4</maven.compile.target>
>  >  >      </properties>
>  >  >  +
>  >  >  +    <profiles>
>  >  >  +        <profile>
>  >  >  +            <id>rc</id>
>  >  >  +            <build>
>  >  >  +                <plugins>
>  >  >  +                    <plugin>
>  >  >  +                        <artifactId>maven-assembly-plugin</artifactId>
>  >  >  +                        <executions>
>  >  >  +                            <execution>
>  >  >  +                                <goals>
>  >  >  +                                    <goal>attached</goal>
>  >  >  +                                </goals>
>  >  >  +                                <phase>package</phase>
>  >  >  +                            </execution>
>  >  >  +                        </executions>
>  >  >  +                    </plugin>
>  >  >  +                </plugins>
>  >  >  +            </build>
>  >  >  +        </profile>
>  >  >  +    </profiles>
>  >  >  +
>  >  >   </project>
>  >  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
In reply to this post by Niall Pemberton
On 2/21/08, Niall Pemberton <[hidden email]> wrote:
>
> Sorry I don't really understand why you're referring to developer
>  pages and pom/skin sites? Where does that come into this?

Someone suggested that I have a page which describes how to build the software.

>
>
>  Niall

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
In reply to this post by Niall Pemberton
On 2/21/08, Niall Pemberton <[hidden email]> wrote:
> I just tried adding this to commons parent - and when I try to run
>  "mvn -Prc install" for commons-parent I get the following error:
>
>  [ERROR] BUILD ERROR
>  [INFO] Error reading assemblies: No assembly descriptors found.
>
>

Did you add it as a build plugin or as a build/plugins/plugin or a
build/pluginManagement/plugins/plugin?

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
On Sat, Feb 23, 2008 at 12:31 PM, James Carman
<[hidden email]> wrote:

> On 2/21/08, Niall Pemberton <[hidden email]> wrote:
>  > I just tried adding this to commons parent - and when I try to run
>  >  "mvn -Prc install" for commons-parent I get the following error:
>  >
>  >  [ERROR] BUILD ERROR
>  >  [INFO] Error reading assemblies: No assembly descriptors found.
>  >
>  >
>
>  Did you add it as a build plugin or as a build/plugins/plugin or a
>  build/pluginManagement/plugins/plugin?

The above makes no sense to me - but I tried the same change as I did for proxy.

Niall

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
On 2/23/08, Niall Pemberton <[hidden email]> wrote:
>  >  Did you add it as a build plugin or as a build/plugins/plugin or a
>  >  build/pluginManagement/plugins/plugin?
>
>
> The above makes no sense to me - but I tried the same change as I did for proxy.
>

From the m2 documentation site:

"Plugin Management contains plugin elements in much the same way,
except that rather than configuring plugin information for this
particular project build, it is intended to configure project builds
that inherit from this one."

So, if you define/configure the plugin within the <pluginManagement>
element, it doesn't get executed for the parent, but it does for the
children.

>
>  Niall
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [hidden email]
>  For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Wendy Smoak
On Sat, Feb 23, 2008 at 10:42 AM, James Carman
<[hidden email]> wrote:

>  From the m2 documentation site:
>
>  "Plugin Management contains plugin elements in much the same way,
>  except that rather than configuring plugin information for this
>  particular project build, it is intended to configure project builds
>  that inherit from this one."
>
>  So, if you define/configure the plugin within the <pluginManagement>
>  element, it doesn't get executed for the parent, but it does for the
>  children.

... only if the child project somehow invokes the plugin.

The pluginManagement section is a "suggestion" to the child project.
If the child project decides to use that plugin, it will get the
configuration from the parent.  But pluginManagement in the parent
will not *cause* the plugin to execute in the child project.

--
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

James Carman
On 2/23/08, Wendy Smoak <[hidden email]> wrote:

> On Sat, Feb 23, 2008 at 10:42 AM, James Carman
>  <[hidden email]> wrote:
>
>  >  From the m2 documentation site:
>  >
>  >  "Plugin Management contains plugin elements in much the same way,
>  >  except that rather than configuring plugin information for this
>  >  particular project build, it is intended to configure project builds
>  >  that inherit from this one."
>  >
>  >  So, if you define/configure the plugin within the <pluginManagement>
>  >  element, it doesn't get executed for the parent, but it does for the
>  >  children.
>
>
> ... only if the child project somehow invokes the plugin.
>
>  The pluginManagement section is a "suggestion" to the child project.
>  If the child project decides to use that plugin, it will get the
>  configuration from the parent.  But pluginManagement in the parent
>  will not *cause* the plugin to execute in the child project.
>

So, how do you say "execute this plugin during the build of my
children, but not during my build"?  We had the same situation at work
and what we ended up doing is creating a different module to be the
parent pom for all modules within our multi-level project structure.

>  --
>
> Wendy
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [hidden email]
>  For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
On Sat, Feb 23, 2008 at 6:08 PM, James Carman
<[hidden email]> wrote:

> On 2/23/08, Wendy Smoak <[hidden email]> wrote:
>  > On Sat, Feb 23, 2008 at 10:42 AM, James Carman
>  >  <[hidden email]> wrote:
>  >
>  >  >  From the m2 documentation site:
>  >  >
>  >  >  "Plugin Management contains plugin elements in much the same way,
>  >  >  except that rather than configuring plugin information for this
>  >  >  particular project build, it is intended to configure project builds
>  >  >  that inherit from this one."
>  >  >
>  >  >  So, if you define/configure the plugin within the <pluginManagement>
>  >  >  element, it doesn't get executed for the parent, but it does for the
>  >  >  children.
>  >
>  >
>  > ... only if the child project somehow invokes the plugin.
>  >
>  >  The pluginManagement section is a "suggestion" to the child project.
>  >  If the child project decides to use that plugin, it will get the
>  >  configuration from the parent.  But pluginManagement in the parent
>  >  will not *cause* the plugin to execute in the child project.
>  >
>
>  So, how do you say "execute this plugin during the build of my
>  children, but not during my build"?  We had the same situation at work
>  and what we ended up doing is creating a different module to be the
>  parent pom for all modules within our multi-level project structure.

Well since its in a "profile" - then I guess we can have different
profiles in commons-parent. Thinking about it, besides components we
have 2 poms (commons-parent and sandbox-parent), commons-skin and
commons-build-plugin. Those probably need their own rc/release
profiles that a different from components (don't need sources, javadoc
or assembly plugins)

Niall

> >
>  > Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r629875 - /commons/proper/proxy/branches/proxy-1.0-work/pom.xml

Niall Pemberton
In reply to this post by Niall Pemberton
On Thu, Feb 21, 2008 at 9:55 PM, Niall Pemberton
<[hidden email]> wrote:

> On Thu, Feb 21, 2008 at 8:15 PM, Niall Pemberton
>
> <[hidden email]> wrote:
>
> > On Thu, Feb 21, 2008 at 6:59 PM, James Carman
>  >  <[hidden email]> wrote:
>  >  > Niall,
>  >  >
>  >  >  Should this sort of thing be in the parent pom?
>  >
>  >  Possibly/probably - every component should have an assembly, but not
>  >  sure if it would mess up doing pom or skin releases which don't.

Thinking about this for commons-parent and commons-sandbox-parent we
just just the "release" profile (don't go thru' rc stage) - I've added
assembly descriptors for jci and commons-build-plugin - so they only
thing remaining is commons-skin - last time we just released directly
using the "release" profile - if it requires a release candidate then
we can just have a profile for it, in its pom.

So I've added this to commons-parent:

http://svn.apache.org/viewvc?view=rev&revision=633587

Niall

>  I just tried adding this to commons parent - and when I try to run
>  "mvn -Prc install" for commons-parent I get the following error:
>
>  [ERROR] BUILD ERROR
>  [INFO] Error reading assemblies: No assembly descriptors found.
>
>  Niall
>
>
>
>  >  Niall
>  >
>  >
>  >
>  >
>  >  >  On 2/21/08, [hidden email] <[hidden email]> wrote:
>  >  >  > Author: niallp
>  >  >  >  Date: Thu Feb 21 09:13:27 2008
>  >  >  >  New Revision: 629875
>  >  >  >
>  >  >  >  URL: http://svn.apache.org/viewvc?rev=629875&view=rev
>  >  >  >  Log:
>  >  >  >  Attach assembly to "package" phase in "rc" profile
>  >  >  >
>  >  >  >  Modified:
>  >  >  >     commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  >
>  >  >  >  Modified: commons/proper/proxy/branches/proxy-1.0-work/pom.xml
>  >  >  >  URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/proxy-1.0-work/pom.xml?rev=629875&r1=629874&r2=629875&view=diff
>  >  >  >  ==============================================================================
>  >  >  >  --- commons/proper/proxy/branches/proxy-1.0-work/pom.xml (original)
>  >  >  >  +++ commons/proper/proxy/branches/proxy-1.0-work/pom.xml Thu Feb 21 09:13:27 2008
>  >  >  >  @@ -260,4 +260,26 @@
>  >  >  >          <maven.compile.source>1.4</maven.compile.source>
>  >  >  >          <maven.compile.target>1.4</maven.compile.target>
>  >  >  >      </properties>
>  >  >  >  +
>  >  >  >  +    <profiles>
>  >  >  >  +        <profile>
>  >  >  >  +            <id>rc</id>
>  >  >  >  +            <build>
>  >  >  >  +                <plugins>
>  >  >  >  +                    <plugin>
>  >  >  >  +                        <artifactId>maven-assembly-plugin</artifactId>
>  >  >  >  +                        <executions>
>  >  >  >  +                            <execution>
>  >  >  >  +                                <goals>
>  >  >  >  +                                    <goal>attached</goal>
>  >  >  >  +                                </goals>
>  >  >  >  +                                <phase>package</phase>
>  >  >  >  +                            </execution>
>  >  >  >  +                        </executions>
>  >  >  >  +                    </plugin>
>  >  >  >  +                </plugins>
>  >  >  >  +            </build>
>  >  >  >  +        </profile>
>  >  >  >  +    </profiles>
>  >  >  >  +
>  >  >  >   </project>
>  >  >  >
>  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]