[text] Deprecate CsvTranslators

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[text] Deprecate CsvTranslators

garydgregory
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Rob Tompkins


> On May 22, 2017, at 7:06 PM, Gary Gregory <[hidden email]> wrote:
>
> Hi All:
>
> I wonder if we should deprecate CsvTranslators in favor of Commons CSV. I
> wish I had noticed CsvTranslators eariler :-(

Seems reasonable to me. Curious if there are general arguments against frequent major version releases? Seems like that would be a bad idea because of bad design, but I'm curious to hear others thoughts in that department.

-Rob

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
Seems reasonable to me as well, should deprecate in text 1.2 release and
code should be move to Commons CSV , I think complete removal should go in
Text 2.0 , whenever it will be.

Regards,
Amey

On Tue, May 23, 2017, 4:41 AM Rob Tompkins <[hidden email]> wrote:

>
>
> > On May 22, 2017, at 7:06 PM, Gary Gregory <[hidden email]>
> wrote:
> >
> > Hi All:
> >
> > I wonder if we should deprecate CsvTranslators in favor of Commons CSV. I
> > wish I had noticed CsvTranslators eariler :-(
>
> Seems reasonable to me. Curious if there are general arguments against
> frequent major version releases? Seems like that would be a bad idea
> because of bad design, but I'm curious to hear others thoughts in that
> department.
>
> -Rob
>
> >
> > Gary
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <
> https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8
> >
> >
> > <http:////
> ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> > JUnit in Action, Second Edition
> > <
> https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22
> >
> >
> > <http:////
> ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> > Spring Batch in Action
> > <
> https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action
> >
> > <http:////
> ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Emmanuel Bourg-3
In reply to this post by garydgregory
Le 23/05/2017 à 01:06, Gary Gregory a écrit :

> I wonder if we should deprecate CsvTranslators in favor of Commons CSV. I
> wish I had noticed CsvTranslators eariler :-(

+1

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

garydgregory
I'm not talking about moving the [text] classes to [csv] but rather I want
folks to use [csv] instead of [txt]. If we have to add a few APIs here and
there fine. But I would hope that all we need is there already.

Gary

On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]> wrote:

> Le 23/05/2017 à 01:06, Gary Gregory a écrit :
>
> > I wonder if we should deprecate CsvTranslators in favor of Commons CSV. I
> > wish I had noticed CsvTranslators eariler :-(
>
> +1
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
+1

On May 25, 2017 1:04 AM, "Gary Gregory" <[hidden email]> wrote:

> I'm not talking about moving the [text] classes to [csv] but rather I want
> folks to use [csv] instead of [txt]. If we have to add a few APIs here and
> there fine. But I would hope that all we need is there already.
>
> Gary
>
> On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]> wrote:
>
> > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> >
> > > I wonder if we should deprecate CsvTranslators in favor of Commons
> CSV. I
> > > wish I had noticed CsvTranslators eariler :-(
> >
> > +1
> >
> > Emmanuel Bourg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22
> >
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
In reply to this post by garydgregory
Hi Gary,

I have deprecated the CsvTranslator from commons text and was looking for
alternate API, we have it in StringEscapeUtils in commons text (and in
commons lang3 which is deprecated & which i'm not worry about), I think we
should remove those csv related methods from StringEscapeUtils as well and
create CsvEscapeUtils in commons CSV as its better place, thoughts ?

Regards,
Amey



On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <[hidden email]>
wrote:

> I'm not talking about moving the [text] classes to [csv] but rather I want
> folks to use [csv] instead of [txt]. If we have to add a few APIs here and
> there fine. But I would hope that all we need is there already.
>
> Gary
>
> On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]> wrote:
>
> > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> >
> > > I wonder if we should deprecate CsvTranslators in favor of Commons
> CSV. I
> > > wish I had noticed CsvTranslators eariler :-(
> >
> > +1
> >
> > Emmanuel Bourg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22
> >
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> 1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



--

---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

garydgregory
I think we need to step back here, or up, and look at the big picture.

Commons CSV reads and writes CSV files. There a couple of additional cases
like writing CSV from JDBC result set.

The Commons Text CSV methods do low level work that is already done within
the guts of Commons CSV.

What is the use case of Commons Text and Lang CSV methods? Build parts of
CSV IO code I would guess.

I do not want to just move code between components in this case. This is
not like WordUtils moving from Lang to Text.

How is this code used? Can a user just do away with it by recoding to
Commons CSV?

Gary

On May 25, 2017 11:26 AM, "Amey Jadiye" <[hidden email]> wrote:

> Hi Gary,
>
> I have deprecated the CsvTranslator from commons text and was looking for
> alternate API, we have it in StringEscapeUtils in commons text (and in
> commons lang3 which is deprecated & which i'm not worry about), I think we
> should remove those csv related methods from StringEscapeUtils as well and
> create CsvEscapeUtils in commons CSV as its better place, thoughts ?
>
> Regards,
> Amey
>
>
>
> On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <[hidden email]>
> wrote:
>
> > I'm not talking about moving the [text] classes to [csv] but rather I
> want
> > folks to use [csv] instead of [txt]. If we have to add a few APIs here
> and
> > there fine. But I would hope that all we need is there already.
> >
> > Gary
> >
> > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]>
> wrote:
> >
> > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> > >
> > > > I wonder if we should deprecate CsvTranslators in favor of Commons
> > CSV. I
> > > > wish I had noticed CsvTranslators eariler :-(
> > >
> > > +1
> > >
> > > Emmanuel Bourg
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > >
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> >
> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1617290459>
> > JUnit in Action, Second Edition
> > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> 18%22
> > >
> >
> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1935182021>
> > Spring Batch in Action
> > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1935182951>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
>
>
> --
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: [hidden email]
>
> For additional commands, e-mail: [hidden email]
>
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
Agreed!, Thanks for sharing thoughts gary, now only marking CsvTranslator
as deprecated will be OK.

I'm marking methods from commons-text StringEscapeUtils as alternative
to CsvTranslator,
Thanks.

Regards,
Amey

On Fri, May 26, 2017 at 12:25 AM, Gary Gregory <[hidden email]>
wrote:

> I think we need to step back here, or up, and look at the big picture.
>
> Commons CSV reads and writes CSV files. There a couple of additional cases
> like writing CSV from JDBC result set.
>
> The Commons Text CSV methods do low level work that is already done within
> the guts of Commons CSV.
>
> What is the use case of Commons Text and Lang CSV methods? Build parts of
> CSV IO code I would guess.
>
> I do not want to just move code between components in this case. This is
> not like WordUtils moving from Lang to Text.
>
> How is this code used? Can a user just do away with it by recoding to
> Commons CSV?
>
> Gary
>
> On May 25, 2017 11:26 AM, "Amey Jadiye" <[hidden email]> wrote:
>
> > Hi Gary,
> >
> > I have deprecated the CsvTranslator from commons text and was looking for
> > alternate API, we have it in StringEscapeUtils in commons text (and in
> > commons lang3 which is deprecated & which i'm not worry about), I think
> we
> > should remove those csv related methods from StringEscapeUtils as well
> and
> > create CsvEscapeUtils in commons CSV as its better place, thoughts ?
> >
> > Regards,
> > Amey
> >
> >
> >
> > On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <[hidden email]>
> > wrote:
> >
> > > I'm not talking about moving the [text] classes to [csv] but rather I
> > want
> > > folks to use [csv] instead of [txt]. If we have to add a few APIs here
> > and
> > > there fine. But I would hope that all we need is there already.
> > >
> > > Gary
> > >
> > > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]>
> > wrote:
> > >
> > > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> > > >
> > > > > I wonder if we should deprecate CsvTranslators in favor of Commons
> > > CSV. I
> > > > > wish I had noticed CsvTranslators eariler :-(
> > > >
> > > > +1
> > > >
> > > > Emmanuel Bourg
> > > >
> > > >
> > > > ------------------------------------------------------------
> ---------
> > > > To unsubscribe, e-mail: [hidden email]
> > > > For additional commands, e-mail: [hidden email]
> > > >
> > > >
> > >
> > >
> > > --
> > > E-Mail: [hidden email] | [hidden email]
> > > Java Persistence with Hibernate, Second Edition
> > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2
> b8>
> > >
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > > 1617290459>
> > > JUnit in Action, Second Edition
> > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> > 18%22
> > > >
> > >
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > > 1935182021>
> > > Spring Batch in Action
> > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > > 1935182951>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> > >
> >
> >
> >
> > --
> >
> > ---------------------------------------------------------------------
> >
> > To unsubscribe, e-mail: [hidden email]
> >
> > For additional commands, e-mail: [hidden email]
> >
>



--

---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

garydgregory
Mentioning the big picture again, Javadocs could also point to Commons CSV.

Gary

On May 25, 2017 12:06 PM, "Amey Jadiye" <[hidden email]> wrote:

> Agreed!, Thanks for sharing thoughts gary, now only marking CsvTranslator
> as deprecated will be OK.
>
> I'm marking methods from commons-text StringEscapeUtils as alternative
> to CsvTranslator,
> Thanks.
>
> Regards,
> Amey
>
> On Fri, May 26, 2017 at 12:25 AM, Gary Gregory <[hidden email]>
> wrote:
>
> > I think we need to step back here, or up, and look at the big picture.
> >
> > Commons CSV reads and writes CSV files. There a couple of additional
> cases
> > like writing CSV from JDBC result set.
> >
> > The Commons Text CSV methods do low level work that is already done
> within
> > the guts of Commons CSV.
> >
> > What is the use case of Commons Text and Lang CSV methods? Build parts of
> > CSV IO code I would guess.
> >
> > I do not want to just move code between components in this case. This is
> > not like WordUtils moving from Lang to Text.
> >
> > How is this code used? Can a user just do away with it by recoding to
> > Commons CSV?
> >
> > Gary
> >
> > On May 25, 2017 11:26 AM, "Amey Jadiye" <[hidden email]> wrote:
> >
> > > Hi Gary,
> > >
> > > I have deprecated the CsvTranslator from commons text and was looking
> for
> > > alternate API, we have it in StringEscapeUtils in commons text (and in
> > > commons lang3 which is deprecated & which i'm not worry about), I think
> > we
> > > should remove those csv related methods from StringEscapeUtils as well
> > and
> > > create CsvEscapeUtils in commons CSV as its better place, thoughts ?
> > >
> > > Regards,
> > > Amey
> > >
> > >
> > >
> > > On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <[hidden email]>
> > > wrote:
> > >
> > > > I'm not talking about moving the [text] classes to [csv] but rather I
> > > want
> > > > folks to use [csv] instead of [txt]. If we have to add a few APIs
> here
> > > and
> > > > there fine. But I would hope that all we need is there already.
> > > >
> > > > Gary
> > > >
> > > > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]>
> > > wrote:
> > > >
> > > > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> > > > >
> > > > > > I wonder if we should deprecate CsvTranslators in favor of
> Commons
> > > > CSV. I
> > > > > > wish I had noticed CsvTranslators eariler :-(
> > > > >
> > > > > +1
> > > > >
> > > > > Emmanuel Bourg
> > > > >
> > > > >
> > > > > ------------------------------------------------------------
> > ---------
> > > > > To unsubscribe, e-mail: [hidden email]
> > > > > For additional commands, e-mail: [hidden email]
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > E-Mail: [hidden email] | [hidden email]
> > > > Java Persistence with Hibernate, Second Edition
> > > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > > > linkCode=as2&tag=garygregory-20&linkId=
> cadb800f39946ec62ea2b1af9fe6a2
> > b8>
> > > >
> > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > > > 1617290459>
> > > > JUnit in Action, Second Edition
> > > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > > > linkCode=as2&tag=garygregory-20&linkId=
> 31ecd1f6b6d1eaf8886ac902a24de4
> > > 18%22
> > > > >
> > > >
> > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > > > 1935182021>
> > > > Spring Batch in Action
> > > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > > > 1935182951>
> > > > Blog: http://garygregory.wordpress.com
> > > > Home: http://garygregory.com/
> > > > Tweet! http://twitter.com/GaryGregory
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > ---------------------------------------------------------------------
> > >
> > > To unsubscribe, e-mail: [hidden email]
> > >
> > > For additional commands, e-mail: [hidden email]
> > >
> >
>
>
>
> --
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: [hidden email]
>
> For additional commands, e-mail: [hidden email]
>
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
Hi Gary, just to conclude the final action and clear midst here, I wish you
and team to elaborate your thought more on.

1. Deprecate CsvTranslator and point javadoc to use same methods present in
StringEscapeUtils in Commons Text.(moved from lang3)

2. Move CsvTranalator to Commons CSV all together.

3. Anything else ?

I like to go with 1st point which I agreed upon before.

Regards,
Amey

On Fri, May 26, 2017, 12:41 AM Gary Gregory <[hidden email]> wrote:

> Mentioning the big picture again, Javadocs could also point to Commons CSV.
>
> Gary
>
> On May 25, 2017 12:06 PM, "Amey Jadiye" <[hidden email]> wrote:
>
> > Agreed!, Thanks for sharing thoughts gary, now only marking CsvTranslator
> > as deprecated will be OK.
> >
> > I'm marking methods from commons-text StringEscapeUtils as alternative
> > to CsvTranslator,
> > Thanks.
> >
> > Regards,
> > Amey
> >
> > On Fri, May 26, 2017 at 12:25 AM, Gary Gregory <[hidden email]>
> > wrote:
> >
> > > I think we need to step back here, or up, and look at the big picture.
> > >
> > > Commons CSV reads and writes CSV files. There a couple of additional
> > cases
> > > like writing CSV from JDBC result set.
> > >
> > > The Commons Text CSV methods do low level work that is already done
> > within
> > > the guts of Commons CSV.
> > >
> > > What is the use case of Commons Text and Lang CSV methods? Build parts
> of
> > > CSV IO code I would guess.
> > >
> > > I do not want to just move code between components in this case. This
> is
> > > not like WordUtils moving from Lang to Text.
> > >
> > > How is this code used? Can a user just do away with it by recoding to
> > > Commons CSV?
> > >
> > > Gary
> > >
> > > On May 25, 2017 11:26 AM, "Amey Jadiye" <[hidden email]> wrote:
> > >
> > > > Hi Gary,
> > > >
> > > > I have deprecated the CsvTranslator from commons text and was looking
> > for
> > > > alternate API, we have it in StringEscapeUtils in commons text (and
> in
> > > > commons lang3 which is deprecated & which i'm not worry about), I
> think
> > > we
> > > > should remove those csv related methods from StringEscapeUtils as
> well
> > > and
> > > > create CsvEscapeUtils in commons CSV as its better place, thoughts ?
> > > >
> > > > Regards,
> > > > Amey
> > > >
> > > >
> > > >
> > > > On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <
> [hidden email]>
> > > > wrote:
> > > >
> > > > > I'm not talking about moving the [text] classes to [csv] but
> rather I
> > > > want
> > > > > folks to use [csv] instead of [txt]. If we have to add a few APIs
> > here
> > > > and
> > > > > there fine. But I would hope that all we need is there already.
> > > > >
> > > > > Gary
> > > > >
> > > > > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <[hidden email]
> >
> > > > wrote:
> > > > >
> > > > > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
> > > > > >
> > > > > > > I wonder if we should deprecate CsvTranslators in favor of
> > Commons
> > > > > CSV. I
> > > > > > > wish I had noticed CsvTranslators eariler :-(
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > Emmanuel Bourg
> > > > > >
> > > > > >
> > > > > > ------------------------------------------------------------
> > > ---------
> > > > > > To unsubscribe, e-mail: [hidden email]
> > > > > > For additional commands, e-mail: [hidden email]
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > E-Mail: [hidden email] | [hidden email]
> > > > > Java Persistence with Hibernate, Second Edition
> > > > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > > > > linkCode=as2&tag=garygregory-20&linkId=
> > cadb800f39946ec62ea2b1af9fe6a2
> > > b8>
> > > > >
> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> > garygregory-20&l=am2&o=1&a=
> > > > > 1617290459>
> > > > > JUnit in Action, Second Edition
> > > > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > > > > linkCode=as2&tag=garygregory-20&linkId=
> > 31ecd1f6b6d1eaf8886ac902a24de4
> > > > 18%22
> > > > > >
> > > > >
> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> > garygregory-20&l=am2&o=1&a=
> > > > > 1935182021>
> > > > > Spring Batch in Action
> > > > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > > > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > > > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
> > garygregory-20&l=am2&o=1&a=
> > > > > 1935182951>
> > > > > Blog: http://garygregory.wordpress.com
> > > > > Home: http://garygregory.com/
> > > > > Tweet! http://twitter.com/GaryGregory
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > ---------------------------------------------------------------------
> > > >
> > > > To unsubscribe, e-mail: [hidden email]
> > > >
> > > > For additional commands, e-mail: [hidden email]
> > > >
> > >
> >
> >
> >
> > --
> >
> > ---------------------------------------------------------------------
> >
> > To unsubscribe, e-mail: [hidden email]
> >
> > For additional commands, e-mail: [hidden email]
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [text] Deprecate CsvTranslators

Amey Jadiye
well, i'm still unclear about the action to be taken here, so i'll keep on
beating a dead horse till we fix it or close it at some logic end.

Regards,
Amey

On Fri, May 26, 2017 at 12:14 PM, Amey Jadiye <[hidden email]> wrote:

> Hi Gary, just to conclude the final action and clear midst here, I wish
> you and team to elaborate your thought more on.
>
> 1. Deprecate CsvTranslator and point javadoc to use same methods present
> in StringEscapeUtils in Commons Text.(moved from lang3)
>
> 2. Move CsvTranalator to Commons CSV all together.
>
> 3. Anything else ?
>
> I like to go with 1st point which I agreed upon before.
>
> Regards,
> Amey
>
>
> On Fri, May 26, 2017, 12:41 AM Gary Gregory <[hidden email]>
> wrote:
>
>> Mentioning the big picture again, Javadocs could also point to Commons
>> CSV.
>>
>> Gary
>>
>> On May 25, 2017 12:06 PM, "Amey Jadiye" <[hidden email]> wrote:
>>
>> > Agreed!, Thanks for sharing thoughts gary, now only marking
>> CsvTranslator
>> > as deprecated will be OK.
>> >
>> > I'm marking methods from commons-text StringEscapeUtils as alternative
>> > to CsvTranslator,
>> > Thanks.
>> >
>> > Regards,
>> > Amey
>> >
>> > On Fri, May 26, 2017 at 12:25 AM, Gary Gregory <[hidden email]>
>> > wrote:
>> >
>> > > I think we need to step back here, or up, and look at the big picture.
>> > >
>> > > Commons CSV reads and writes CSV files. There a couple of additional
>> > cases
>> > > like writing CSV from JDBC result set.
>> > >
>> > > The Commons Text CSV methods do low level work that is already done
>> > within
>> > > the guts of Commons CSV.
>> > >
>> > > What is the use case of Commons Text and Lang CSV methods? Build
>> parts of
>> > > CSV IO code I would guess.
>> > >
>> > > I do not want to just move code between components in this case. This
>> is
>> > > not like WordUtils moving from Lang to Text.
>> > >
>> > > How is this code used? Can a user just do away with it by recoding to
>> > > Commons CSV?
>> > >
>> > > Gary
>> > >
>> > > On May 25, 2017 11:26 AM, "Amey Jadiye" <[hidden email]> wrote:
>> > >
>> > > > Hi Gary,
>> > > >
>> > > > I have deprecated the CsvTranslator from commons text and was
>> looking
>> > for
>> > > > alternate API, we have it in StringEscapeUtils in commons text (and
>> in
>> > > > commons lang3 which is deprecated & which i'm not worry about), I
>> think
>> > > we
>> > > > should remove those csv related methods from StringEscapeUtils as
>> well
>> > > and
>> > > > create CsvEscapeUtils in commons CSV as its better place, thoughts ?
>> > > >
>> > > > Regards,
>> > > > Amey
>> > > >
>> > > >
>> > > >
>> > > > On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <
>> [hidden email]>
>> > > > wrote:
>> > > >
>> > > > > I'm not talking about moving the [text] classes to [csv] but
>> rather I
>> > > > want
>> > > > > folks to use [csv] instead of [txt]. If we have to add a few APIs
>> > here
>> > > > and
>> > > > > there fine. But I would hope that all we need is there already.
>> > > > >
>> > > > > Gary
>> > > > >
>> > > > > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <
>> [hidden email]>
>> > > > wrote:
>> > > > >
>> > > > > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
>> > > > > >
>> > > > > > > I wonder if we should deprecate CsvTranslators in favor of
>> > Commons
>> > > > > CSV. I
>> > > > > > > wish I had noticed CsvTranslators eariler :-(
>> > > > > >
>> > > > > > +1
>> > > > > >
>> > > > > > Emmanuel Bourg
>> > > > > >
>> > > > > >
>> > > > > > ------------------------------------------------------------
>> > > ---------
>> > > > > > To unsubscribe, e-mail: [hidden email]
>> > > > > > For additional commands, e-mail: [hidden email]
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > > > --
>> > > > > E-Mail: [hidden email] | [hidden email]
>> > > > > Java Persistence with Hibernate, Second Edition
>> > > > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
>> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
>> > > > > linkCode=as2&tag=garygregory-20&linkId=
>> > cadb800f39946ec62ea2b1af9fe6a2
>> > > b8>
>> > > > >
>> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
>> > garygregory-20&l=am2&o=1&a=
>> > > > > 1617290459>
>> > > > > JUnit in Action, Second Edition
>> > > > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
>> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
>> > > > > linkCode=as2&tag=garygregory-20&linkId=
>> > 31ecd1f6b6d1eaf8886ac902a24de4
>> > > > 18%22
>> > > > > >
>> > > > >
>> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
>> > garygregory-20&l=am2&o=1&a=
>> > > > > 1935182021>
>> > > > > Spring Batch in Action
>> > > > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
>> > > > > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
>> > > > > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
>> > > > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=
>> > garygregory-20&l=am2&o=1&a=
>> > > > > 1935182951>
>> > > > > Blog: http://garygregory.wordpress.com
>> > > > > Home: http://garygregory.com/
>> > > > > Tweet! http://twitter.com/GaryGregory
>> > > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > >
>> > > > ------------------------------------------------------------
>> ---------
>> > > >
>> > > > To unsubscribe, e-mail: [hidden email]
>> > > >
>> > > > For additional commands, e-mail: [hidden email]
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> >
>> > ---------------------------------------------------------------------
>> >
>> > To unsubscribe, e-mail: [hidden email]
>> >
>> > For additional commands, e-mail: [hidden email]
>> >
>>
>


--

---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]